-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added waylandcompositor plugin deployer #157
Conversation
@TheAssassin any chance on getting this merged? |
Sorry, totally missed your PR. Too much other things to worry about. I'll have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Is there any reason you need to deploy this manually other than the fact that the plugin still prefers X11 (which causes less of a headache)? I mean, it's fine the way it is, just curious. |
Thank you! I'd appreciate a reply nevertheless. |
Sorry for the late reply. I simply wanted my app to work with wayland as well. There was no special reason other than I had nothing to do at work :D |
@SushiTee I think the main question is whether there a reason to not ship these plugins? Likely everybody would like their app to work with Wayland as well, so unless there are reasons not to support this, shipping the necessary plugins should potentially be an opt-out instead of an opt-in. |
True. In my case the app just works with both. On systems without wayland support or where it is simply not the default the app starts using XCB without problems. |
I added a class to deploy the following 3 plugin directories:
when the plugin waylandcompositor is selected.
I confirmed my specific app working with wayland like this. Here are the environment variables I set: