chore: switch tray items to listview #734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zsien The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zsien
force-pushed
the
zs/chore/trayanimation
branch
from
6fd51ad
to
209a929
Compare
BLumia
requested changes
Aug 30, 2024
There was a problem hiding this comment.
之前是这里一开始没用 ListView 是因为 ListView 无法满足设计给定的动画要求。这里的动画要求非常复杂（细节你可以当面给 @tsic404 核对一下），此 PR 当前实现导致相应动画需求完全丢失，是不可接受的。
此外，Stash 区域的 item 存在不必要的动画，tray 区域拖拽时实时更新位置的动画也未实现，从快捷面板拖拽驻留的需求看上去也失效了。
（ps. Stash 区域最初没用 GridView 也是考虑到最初说允许 GridView 出现尺寸非固定的元素可能一个元素占据多个格子。目前没有再收到此类需求了，所以 Stash 区域改 GridView 应该问题不大）
zsien
force-pushed
the
zs/chore/trayanimation
branch
2 times, most recently
from
f6ae995
to
608a828
Compare
* tray 使用 listview 实现 * stashed 使用 grid 实现 * 修改 traysortordermodel Issues: linuxdeepin/developer-center#10198
* 修复拖动到 show stash action 时崩溃 * 修复拖动后位置不变时崩溃
清理代码
zsien
force-pushed
the
zs/chore/trayanimation
branch
from
608a828
to
acb9ae2
Compare
增加覆盖整个 tray 区域的 DropArea
deepin pr auto reviewFix the TraySortOrderModel to work with the new model |
|
这个修改后托盘的效果没有达到之前的动画效果吧？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: linuxdeepin/developer-center#10198