-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xxx0 maximized (t400 x200) #953
Conversation
2ef10e1
to
259e422
Compare
Needs #954 related changes |
Tested on T400 and its not working. https://app.circleci.com/pipelines/github/tlaurion/heads/685/workflows/4a79bc0b-d2fb-40fd-b410-7e0a314832e2/jobs/756/artifacts |
So I guess x200 won't work either. Will find my old machine and test in the next weeks on it. |
I tested removing the CD/DVD-Drive and the wifi-card. No change. |
@fhvyhjriur nope it is not. Could bring the changes from an old devel branch. Will do. |
Found trace of my last debugging attempt here (just to have a trace) #700 (comment) |
config, fstab and other changes to pick from: master...tlaurion:x230-debug |
Trace for screwdriver setup, used in the past to troubleshoot what was happening on x220 when debug was needed #541 (comment) |
Any help welcome, that was it for today. Basically, needed to be added under coreboot conf:
Then on beaglebone black turned into screwdriver USB DEBUG dongle: #541 (comment) |
Also note TPM-less limit of current HOTP USB Security dongle current added security here @fhvyhjriur please confirm interest in TPM-less GM45 based platforms. |
I confirm interest in TPM-less GM45 based plattforms. At the moment the t400 is sitting there with the non working image. Is there any image i can flash external with debugging output enabled? Then i could provide the debugging logs. |
@fhvyhjriur I forced push t400-maximized, t400-maximized-debug and x200-maximized under this PR. Added t400-maximized-debug per last comment. Please test and post results.
As you can see in cbde51f adapting IS NOT HARD. I expect users to be collaborators for such requests. Afterall, Heads is a coreboot config + linux config to support a new board. So tweaking of those should be possible without too much of a learning curve. |
cd ~/heads/build/coreboot-4.8.1/util/bincfg | ||
make gen-gbe-ich9m | ||
make gen-ifd-x200 | ||
mv flashregion_0_fd.bin ../../../../blobs/xxx0/ifd.bin | ||
mv flashregion_3_gbe.bin ../../../../blobs/xxx0/gbe.bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fhvyhjriur as you can see, the ifd.bin and gbe.bin blobs were generated. If board is beeping on boot, it is most probably because something is wrong there.
ifd.bin: OK | ||
|
||
IFD contains regions that were outputed to layout.txt through ifdtool -f layout.txt ifd.bin | ||
It defines a BIOS region of 007fffff – 00003000 = 7FCFFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This size is reflected under coreboot config. When boards are not booting (different then beeping), in the past it was because of a size mismatch between ifd defined regions and CBFS_SIZE defined under coreboot config.
Note that first boot after flash might take a couple of seconds more since memory init is done the first time and results need to be injected in CBFS as well.
# Configuration for a t400 running non-Qubes OSes with USBDEBUG activated under coreboot config | ||
# | ||
# Deactivated to fit in coreboot's CONFIG_CBFS_SIZE=0x7FCFFF: | ||
# dropbear support(ssh client/server) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be reactivated. When looking at output of builds, there is still of space for 8mb ROMs.
Note that really soon, bash will be included in roms, taking 150kb of CBFS space.
CONFIG_GBE_BIN_PATH="@BLOB_DIR@/xxx0/gbe.bin" | ||
CONFIG_HAVE_IFD_BIN=y | ||
CONFIG_BOARD_LENOVO_T400=y | ||
CONFIG_LINUX_COMMAND_LINE="intel_iommu=igfx_off quiet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was different in past commit. I do not remember why different OS kernel tweaks were passed before.
@@ -0,0 +1,15 @@ | |||
CONFIG_VENDOR_LENOVO=y | |||
CONFIG_CBFS_SIZE=0x7FCFFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From README notes, based on ifdtool -f output saved under layout.txt, where end-begin of BIOS REGION gives that value,.
CONFIG_GBE_BIN_PATH="@BLOB_DIR@/xxx0/gbe.bin" | ||
CONFIG_HAVE_IFD_BIN=y | ||
CONFIG_BOARD_LENOVO_X200=y | ||
CONFIG_LINUX_COMMAND_LINE="intel_iommu=igfx_off quiet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Heads kernel options passed from coreboot to the kernel Heads is booting.
As of now, nothing is tweaked here for i915/drm driver and coreboot boots without IGFX_INIT, meaning that the kernel is seldom responsible for graphic initialization.
linux config, as specified in board config, reuses linux-x230-legacy.conf, which includes i915 and i915 drm drivers. It should just work (tm).
@fhvyhjriur I took time and flashed https://output.circle-artifacts.com/output/job/f7ee6a22-6607-4471-b01d-7eccef45582f/artifacts/0/build/x86/x200-maximized/heads-x200-maximized-v0.2.0-1401-gcbde51f.rom onto my x200 vPro. Boots into Heads successfully with fbwhiptail (default for all laptops/workstations). |
There is around 1mb free in current state under 8mb SPI (vPro x200 stickers). |
@fhvyhjriur If you want the t400/x200 board to be put upstream to have images being built for each commit, please do not let this bitrot too long.... I took the time to do this, tested it on x200 vpro, it works. Thank you for your understanding. |
Hello, I would be available to test an X200 build. I came across Heads recently, and am happy to help work towards upstreaming the work you've done for this laptop I have on-hand. I can't test immediately since I have 4mb flash installed currently. However, I believe (via https://libreboot.org/docs/hardware/x200.html) swapping in a 16mb flash should allow me to test this. |
This PR is old and would need work to match upstream. Also, board configs were for the 8mb chip matching x200 vPro. It would not be difficult to create different board configs for 8mb and 16mb though, mostly being different coreboot configs specifying rom size and cbfs sizes correctly. Board names would need to be clear about it. @jleightcap tag me when you have swapped to 16mb and have libreboot working on it? |
This PR is old and would need work to match upstream. Also, board configs were
for the 8mb chip matching x200 vPro.
I can tackle this as I get closer to being able to test it. Thanks for the tip.
It would not be difficult to create different board configs for 8mb and 16mb
though, mostly being different coreboot configs specifying rom size and cbfs
sizes correctly.
Board names would need to be clear about it.
@jleightcap tag me when you have swapped to 16mb and have libreboot working on
it?
Will do!
|
I am sorry for missing the builds more then a year ago. You told that you would like to not build images for devices with a OEM SPI size of 8 and not expect many people upgrading the SPI chips to 16 like i mostly do. |
Do you see a purpose in testing this and maintaining this @fhvyhjriur ? This is one commit, I can easily merge master here which will trigger a rebuild. |
I can test T400 again like i did before when its not a problem to trigger a rebuild again. I can test from time to time and report when it broken when this is fulfills the requirement of maintaining. |
I finaly aquire another hardware to replace my deprecated broken one, happy to test this finally has promised will continue on chat. Cheers Irelativism. |
I've lost all interest i'm sorry. |
Bringing those boards alive will need to come from a community member willing to maintain it, I drop that ball, nobody cared enough since 2021 where I lost my time and energy on those way too much already. PR welcome. |
Forced pushed t400/x200 and t400-debug to commit cbde51f on March 03 2023.
Builds can be tested for 30 days under CircleCI for that commit (click green mark, go to board, select artifacts tab, download ROM and flash).
@fhvyhjriur please test and report in this PR (t400 and x200 only since I own x200 and you own t400).
TODO: