use list of parameters for ansible conditions #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…internally identical to using logical 'and' operator
pcahyna
reviewed
Sep 25, 2019
| when: timesync_mode == 2 and timesync_mode2_hwts | ||
| when: | ||
| - timesync_mode == 2 | ||
| - timesync_mode2_hwts |
There was a problem hiding this comment.
Is this really guaranteed to be identical? I am asking because Ansible handles bare variables specially. See ansible/ansible#39414 ansible/ansible#51030 ansible/ansible#60943
pcahyna
reviewed
Sep 25, 2019
| when: timesync_mode == 2 and timesync_mode2_hwts | ||
| when: | ||
| - timesync_mode == 2 | ||
| - timesync_mode2_hwts |
vcrhonek
added a commit
to vcrhonek/timesync
that referenced
this pull request
Sep 26, 2019
…le condition. This is just comsetic followup to linux-system-roles#36 with intention to make the role consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce number of long lines by using list of conditions.
As per ansible docs:
To be consistent, lists are used everywhere where there is more than one condition