tests: Do not 'fips-mode-setup' to enable FIPS on RHEL 10 #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fips-mode-setup tools is being removed from RHEL. Strarting with RHEL 10 adding fips=1 to the boot cmdline is enough to enable FIPS.
|
Marking as draft for now, because all the pieces required for just the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
- Coverage 16.54% 10.73% -5.81%
==========================================
Files 2 8 +6
Lines 284 1946 +1662
Branches 79 0 -79
==========================================
+ Hits 47 209 +162
- Misses 237 1737 +1500
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
spetrosi
reviewed
Nov 5, 2024
| - name: Reboot | ||
| reboot: | ||
| test_command: grep 1 /proc/sys/crypto/fips_enabled | ||
| - name: Enable FIPS mode (RHEL 8 and 9) |
There was a problem hiding this comment.
Missing newline
Suggested change
| - name: Enable FIPS mode (RHEL 8 and 9) | |
| - name: Enable FIPS mode (RHEL 8 and 9) |
spetrosi
approved these changes
Nov 5, 2024
richm
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fips-mode-setup tools is being removed from RHEL. Strarting with RHEL 10 adding fips=1 to the boot cmdline is enough to enable FIPS.