Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add stas_data volume to fix last-known-config.pickle issue #251

Closed
wants to merge 1 commit into from
Closed

docker: add stas_data volume to fix last-known-config.pickle issue #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,25 @@ x-stas: &default-stas
volumes:
- /run/dbus:/run/dbus
- /etc/nvme:/etc/nvme
- stas_data:/run/stas
privileged: true
network_mode: host

services:
stafd:
<<: *default-stas
environment:
RUNTIME_DIRECTORY: /run/stafd
RUNTIME_DIRECTORY: /run/stas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If both stafd and stacd use the same directory (/run/stas) they will overwrite each others files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they run in different containers, so no override here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they run in separate containers, but aren't they writing to the host's /run directory? If that's the case, they will both write to the same host directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only mount host /run/dbus and /etc/nvme to inside the containers
let me re-check about new stas_data I added...

XDG_CACHE_HOME: /var/cache/stafd
PYTHONUNBUFFERED: 1
command: -u /usr/sbin/stafd
stacd:
<<: *default-stas
environment:
RUNTIME_DIRECTORY: /run/stacd
RUNTIME_DIRECTORY: /run/stas
XDG_CACHE_HOME: /var/cache/stacd
PYTHONUNBUFFERED: 1
command: -u /usr/sbin/stacd

volumes:
stas_data: