Add correct git version to AppImage #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a static build target. Signed-off-by: Daniel Wagner <[email protected]>
Show which git version is used when configuration phase. Signed-off-by: Daniel Wagner <[email protected]>
In order to build a image with which contains the correct git version SHA we need to fetch the complete git tree. Otherwise 'git describe' fails and we use the project version string as fallback. Signed-off-by: Daniel Wagner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github checkout action is trying to be smart and breaks
git describein the process. Checkout the complete history so that we can do agit describe. Maybe there is a better strategy to get an usable git version string into the build. But for the time being, let's do the simplest thing and clone the complete repo.Fixes: #2410