nvme-print-binary: add effects-log command output missed #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The csi data added before effects log page output. Signed-off-by: Tokunori Ikegami <[email protected]>
|
Fix for the isseu #2405. |
|
The 1.16 code base only prints the effects log in binary mode. Is this something we should/need to keep? |
|
The effects log was changed by 155fbeb to add CSI but looks not applied the changes in the 1.16 code. So currently multiple CSIs effects logs are output then if not added the CSI data then seems difficult to know which CSI effects log from the binary output. But still should we keep the output before? |
|
I suppose the main use case is to store it into a file and do some operation on it. I was wondering if we mix different section into the output it makes it hard to use. But the CSI section and the effect section have a fixed size. Alright, let's go with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The csi data added before effects log page output.