Use libnvme helper to retrieve hostnqn/hostid #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
changed the title
|
Well, there is some more to fix with the config.json connect all code path when there is only the config.json file around. |
igaw
force-pushed
the
hostnqn-order
branch
2 times, most recently
from
544c362 to
659f24b
Compare
Fetch hostnqn changes. Signed-off-by: Daniel Wagner <[email protected]>
Simplify the error handling path by using the cleanup helpers. Signed-off-by: Daniel Wagner <[email protected]>
The 'already connected' message only contains the traddr as info. Add the missing information so that it's possible to figure out what combination is already in use. Signed-off-by: Daniel Wagner <[email protected]>
libnvme provides a handy new helper to lookup the hostnqn and hostid. Signed-off-by: Daniel Wagner <[email protected]>
The topology scanning will create nodes in the internal libnvme tree. As we rely on the order of the nodes in the tree, we need to read the config before we scan. This makes sure the first node is the one we have defined in the config.json. This is important because the first node provides default hosnqn configuration in absents of /etc/nvme/hostnqn. Signed-off-by: Daniel Wagner <[email protected]>
Move the connect logic out of the subsystem, ctrl loop. Too much indention. Signed-off-by: Daniel Wagner <[email protected]>
Iterate over all hosts defined in the config.json configuration file, instead just the default controller. Signed-off-by: Daniel Wagner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several places to lookup the default hostnqn/hostid. Add a helper which implements a canonical way to do this.
Fixes: ##1956
Depends: linux-nvme/libnvme#857