Documentation: teaching: labs: kernel_api: Fix indentation for exercises TODOs #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavip
pushed a commit
to linux-kernel-labs/linux-kernel-labs.github.io
that referenced
this pull request
Mar 2, 2020
valighita
force-pushed
the
vghita/labs/kernel_api/content_fixes
branch
from
60d97b0
to
3af818f
Compare
tavip
pushed a commit
to linux-kernel-labs/linux-kernel-labs.github.io
that referenced
this pull request
Mar 2, 2020
valighita
changed the title
valighita
requested review from
claudiughioc,
razvand,
Sergiu121 and
teoserbanescu
| @@ -716,26 +716,26 @@ free them (in :c:func:`memory_exit`). | |||
| (use :c:func:`kfree`). | |||
|
|
|||
| .. hint:: | |||
There was a problem hiding this comment.
I think you also need to fix the indentation for this line and the following note:: and hint:: in this TODO.
There was a problem hiding this comment.
No, I indented only the ones related to the TODO above them. These two apply to the whole exercise.
There was a problem hiding this comment.
Ok, thank you for the explanation.
teoserbanescu
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.