tools/labs: Change make clean rule to only remove generated files #145
Conversation
Sergiu121
requested review from
dbaluta,
tavip,
razvand,
claudiughioc,
valighita,
teoserbanescu,
StefanTeodorescu,
mhpopescu and
alexandrumc
| @@ -39,6 +39,12 @@ docs: | |||
| cp -r $(KDIR)/Documentation/output/slides/teaching/_static $(KDIR)/Documentation/output/teaching/ | |||
|
|
|||
| clean:: | |||
There was a problem hiding this comment.
That's not a typo. It's Makefile syntax for running multiple clean targets. There's a clean target in this file, and there's another "clean::" in "qemu/Makefile", which is included. By using "clean::" you run both clean targets:
https://web.archive.org/web/20180122002430/http://owen.sj.ca.us/~rk/howto/slides/make/slides/makecolon.html
tools/labs/Makefile
Outdated
| @@ -39,6 +39,12 @@ docs: | |||
| cp -r $(KDIR)/Documentation/output/slides/teaching/_static $(KDIR)/Documentation/output/teaching/ | |||
|
|
|||
| clean:: | |||
| -rm -rf skels | |||
| find skels -type f \( -name *.mod.* -or -name *.ko -or -executable -or -name *.cmd -or -name *.o \) | xargs --no-run-if-empty rm || true | |||
There was a problem hiding this comment.
You don't need to add || true. You can just prefix the command with - (minus). See https://stackoverflow.com/a/3477400/4804196.
There was a problem hiding this comment.
It make be that we want to have executable files or object files as part of the skeleton. So maybe removing those isn't the way to go.
The best way would be to look for all Makefile files and call make -C $MAKEFILE_DIR clean, where $MAKEFILE_DIR is the directory where the Makefile exists.
|
|
||
| .PHONY: skels build copy docs clean | ||
| clean_skels: | ||
| rm -rf skels |
There was a problem hiding this comment.
We should do this in a later PR.
Signed-off-by: Sergiu Weisz <[email protected]>
Sergiu121
force-pushed
the
infra/Makefiles
branch
from
d8c2120
to
b6fedc0
Compare
Address issue #134 by moving the deletion of the skels directory to another target, and change the clean target to only delete generated files