Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove yidas/yii2-bower-asset dependency #89

Closed
wants to merge 1 commit into from
Closed

Remove yidas/yii2-bower-asset dependency #89

wants to merge 1 commit into from

Conversation

vitalyzhakov
Copy link
Contributor

@vitalyzhakov vitalyzhakov commented Jan 21, 2021 •
edited
Loading

yidas/yii2-bower-asset removes

  • bower-asset/yii2-pjax
  • bower-asset/punycode
  • bower-asset/jquery
  • bower-asset/inputmask

but they are required for yii2 web projects(

composer 2.0.8,
php 7.4.3

solve #88

@vitalyzhakov
Copy link
Contributor Author

@linslin , hello!
Can you approve it?

@linslin
Copy link
Owner

linslin commented Feb 1, 2021

Many thanks for this. Please create a new PR pointing on the develop branch. We driving "gitflow"! Thanks!

@linslin linslin closed this Feb 1, 2021
@vitalyzhakov
Copy link
Contributor Author

@linslin , no problem,
PR pointing to the develop branch #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitalyzhakov @linslin