ef.core 7 support #263
Merged
ef.core 7 support #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaceWindu
force-pushed
the
infra/net7-migration
branch
from
5835913
to
88a81a7
Compare
sdanyliv
reviewed
Nov 12, 2022
| @@ -14,8 +14,8 @@ | |||
| <projectUrl>https://github.com/linq2db/linq2db.EntityFrameworkCore</projectUrl> | |||
| <license type="file">MIT-LICENSE.txt</license> | |||
| <dependencies> | |||
| <group targetFramework=".NETStandard2.1"> | |||
| <dependency id="Microsoft.EntityFrameworkCore.Relational" version="5.0.17" /> | |||
| <group targetFramework="net6.0"> | |||
There was a problem hiding this comment.
sdanyliv
reviewed
Nov 12, 2022
| @@ -600,19 +599,19 @@ string PrepareExpressionText(Expression? expr) | |||
| { | |||
| // Handling NpgSql's PostgresBinaryExpression | |||
|
|
|||
| var left = newExpression.GetType().GetProperty("Left")?.GetValue(newExpression) as Expression; | |||
| var right = newExpression.GetType().GetProperty("Right")?.GetValue(newExpression) as Expression; | |||
| var left = (Expression)newExpression.GetType().GetProperty("Left")?.GetValue(newExpression)!; | |||
There was a problem hiding this comment.
I mean this code will throw exception.
There was a problem hiding this comment.
class SqlExpression: Expression {...}
sdanyliv
reviewed
Nov 12, 2022
| @@ -278,7 +277,7 @@ static DataType DbTypeToDataType(DbType dbType) | |||
| { | |||
| (T)(Attribute)new ColumnAttribute | |||
| { | |||
| Name = prop.GetColumnName(storeObjectId!.Value), | |||
| Name = storeObjectId != null ? prop.GetColumnName(storeObjectId.Value) : null, | |||
There was a problem hiding this comment.
storeObjectId is not value type anymore?
There was a problem hiding this comment.
It is, but there were assumption that GetStoreObjectIdentifier will return non-null value. I'm not sure it is always true, so I've replaced code a bit to treat it as nullable value to avoid NRE
sdanyliv
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #262
masterbranch updated to ef.core 7 (was v5). v5 moved to separate branchPomelo.EntityFrameworkCore.MySqldoesn't have v7 support yet Upgrade to EF Core 7.0.0 PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#1717Code based on v6 version, so there is more changes than expected due to fact that master had v5