Simplfy min replicas #272
Merged
Simplfy min replicas #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make min replicas reponsible for Ready status not Synced - Remove min-replicas from autopause check - Only pause when Ready and Synced
mhmxs
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Previously,
min-replicasapplied to the number of backends on which the bucket should be updated before it can be considered Synced. This change means thatmin-replicasnow applies to the number of backends on which the bucket should be created before it can be considered Ready. This means we only consider a bucket Synced when it is successfully updated on all backends.The reason for the change is that with the introduction of more sub-resources such as Versioning (and planned Locking), it is problematic to consider a Bucket to be Synced if sub resources such as Versioning have not been enforced on all backends. We need to avoid a situation where, for example, a Bucket is considered Synced, but of it's three backends Versioning has been enabled on backends 1 and 2, while Locking has been enabled on backends 2 and 3. If the Bucket is then paused, the Bucket will be stuck in this scenario but seen as Synced by the user.
The easiest remedy is to simplify this process and only consider a bucket Synced once it is available on all backends, and only then pause the bucket (should auto-pause be enabled).
I have:
make reviewableto ensure this PR is ready for review.make ceph-chainsawto validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours betwee it and Ceph. Seedocs/TESTING.mdfor information on how to run tests against a Ceph cluster.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Updated chainsaw and a lot of unit tests