Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go version of CodeQL action #134

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Upgrade Go version of CodeQL action #134

merged 1 commit into from
Jan 11, 2024

Conversation

mhmxs
Copy link
Contributor

@mhmxs mhmxs commented Jan 11, 2024

CodeQL action needs up to date Go version 1.21.

This workaournds needs because of this issue: github/codeql#13992 (comment)

@mhmxs mhmxs requested a review from nolancon January 11, 2024 11:16
@@ -5,6 +5,7 @@ on:
branches:
- main
- release-*
- fix-codeql-*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this or was it just for testing purposes?

Copy link
Contributor Author

@mhmxs mhmxs Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nolancon I strongly think this should be permanent, to test pipeline. I like it :) WDYT?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me 👍

@mhmxs mhmxs merged commit ffa825d into main Jan 11, 2024
14 checks passed
@mhmxs mhmxs deleted the fix-codeql-goversion branch January 11, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants