Support versioning (#268)

* Add VersioningConfiguration APIs

* Add subresource versioning

* Add versioning configuration subresource unit tests

* Add chainsaw tests cases

* Additional unit tests for updated subresources

apis/provider-ceph/v1alpha1/bucket_types.go

@@ -82,6 +82,12 @@ type BucketParameters struct {
 	// +optional
 	LifecycleConfiguration *BucketLifecycleConfiguration `json:"lifecycleConfiguration,omitempty"`
 
+	// VersioningConfiguration describes the desired versioning state of an S3 bucket.
+	// See the API reference guide for PutBucketVersioning for usage and error information.
+	// See also, https://docs.aws.amazon.com/goto/WebAPI/s3-2006-03-01/PutBucketVersioning
+	// +optional
+	VersioningConfiguration *VersioningConfiguration `json:"versioningConfiguration,omitempty"`
+
 	// AssumeRoleTags may be used to add custom values to an AssumeRole request.
 	// +optional
 	AssumeRoleTags []Tag `json:"assumeRoleTags,omitempty"`
@@ -98,10 +104,16 @@ type BucketParameters struct {
 type BackendInfo struct {
 	// BucketCondition is the condition of the Bucket on the S3 backend.
 	BucketCondition xpv1.Condition `json:"bucketCondition,omitempty"`
+	// +optional
 	// LifecycleConfigurationCondition is the condition of the bucket lifecycle
 	// configuration on the S3 backend. Use a pointer to allow nil value when
 	// there is no lifecycle configuration.
 	LifecycleConfigurationCondition *xpv1.Condition `json:"lifecycleConfigurationCondition,omitempty"`
+	// +optional
+	// VersioningConfigurationCondition is the condition of the versioning
+	// configuration on the S3 backend. Use a pointer to allow nil value when
+	// there is no versioning configuration.
+	VersioningConfigurationCondition *xpv1.Condition `json:"versioningConfigurationCondition,omitempty"`
 }
 
 // Backends is a map of the names of the S3 backends to BackendInfo.

apis/provider-ceph/v1alpha1/versioningconfiguration_types.go

@@ -0,0 +1,28 @@
+package v1alpha1
+
+type VersioningStatus string
+
+const (
+	VersioningStatusEnabled   VersioningStatus = "Enabled"
+	VersioningStatusSuspended VersioningStatus = "Suspended"
+)
+
+type MFADelete string
+
+const (
+	MFADeleteEnabled  MFADelete = "Enabled"
+	MFADeleteDisabled MFADelete = "Disabled"
+)
+
+// VersioningConfiguration describes the versioning state of an S3 bucket.
+type VersioningConfiguration struct {
+	// MFADelete specifies whether MFA delete is enabled in the bucket versioning configuration.
+	// This element is only returned if the bucket has been configured with MFA
+	// delete. If the bucket has never been so configured, this element is not returned.
+	// +kubebuilder:validation:Enum=Enabled;Disabled
+	MFADelete *MFADelete `json:"mfaDelete,omitempty"`
+
+	// Status is the desired versioning state of the bucket.
+	// +kubebuilder:validation:Enum=Enabled;Suspended
+	Status *VersioningStatus `json:"status,omitempty"`
+}

e2e/tests/ceph/chainsaw-test.yaml

@@ -135,7 +135,7 @@ spec:
         - $CEPH_ADDRESS
         entrypoint: ../../../hack/expect_bucket.sh
 
-  - name: Apply lifecycle configuration to test-bucket.
+  - name: Apply lifecycle configuration and versioning configuration to test-bucket.
     try:
     - apply:
         resource: 
@@ -147,6 +147,8 @@ spec:
             providers:
             - ceph-cluster
             forProvider:
+              versioningConfiguration:
+                status: "Enabled"
               lifecycleConfiguration:
                 # Example rules from https://docs.aws.amazon.com/AmazonS3/latest/userguide/lifecycle-configuration-examples.html
                 rules:
@@ -195,6 +197,10 @@ spec:
                     reason: Available
                     status: "True"
                     type: Ready
+                  versioningConfigurationCondition:
+                    reason: Available
+                    status: "True"
+                    type: Ready
             conditions:
             - reason: Available
               status: "True"
@@ -203,7 +209,7 @@ spec:
               status: "True"
               type: Synced
 
-  - name: Disable lifecycle configuration on test-bucket.
+  - name: Disable lifecycle configuration and remove versioning configuration on test-bucket.
     try:
     - apply:
         resource:
@@ -218,6 +224,7 @@ spec:
             - ceph-cluster
             lifecycleConfigurationDisabled: true
             forProvider:
+              versioningConfiguration:
               lifecycleConfiguration:
                 # Example rules https://docs.aws.amazon.com/AmazonS3/latest/userguide/lifecycle-configuration-examples.html
                 rules:
@@ -262,6 +269,10 @@ spec:
                     reason: Available
                     status: "True"
                     type: Ready
+                  versioningConfigurationCondition:
+                    reason: Available
+                    status: "True"
+                    type: Ready
             conditions:
             - reason: Available
               status: "True"