Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [M3-8927] – Upgrade eslint in api-v4 and validation packages to address cross-spawn alert #11352

Closed

Conversation

dwiley-akamai
Copy link
Contributor

Description πŸ“

Upgrade eslint in api-v4 and validation packages to address cross-spawn alert.

(see #11285 for additional context)

Target release date πŸ—“οΈ

12/10/24

Preview πŸ“·

Before After
Screenshot 2024-12-02 at 5 51 06β€―PM Screenshot 2024-12-02 at 5 51 23β€―PM

Observe: "eslint#[email protected]" is no longer found

How to test πŸ§ͺ

Verification steps

  • App should build successfully
  • Storybook should build successfully
  • Checks should pass
  • You can run yarn why cross-spawn locally as in the Preview section and confirm you observe the same
Author Checklists

As an Author, to speed up the review process, I considered πŸ€”

πŸ‘€ Doing a self review
❔ Our contribution guidelines
🀏 Splitting feature into small PRs
βž• Adding a changeset
πŸ§ͺ Providing/improving test coverage
πŸ” Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
πŸ‘£ Providing comprehensive reproduction steps
πŸ“‘ Providing or updating our documentation
πŸ•› Scheduling a pair reviewing session
πŸ“± Providing mobile support
β™Ώ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed βœ…

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@dwiley-akamai dwiley-akamai added the Dependencies Pull requests that update a dependency file label Dec 2, 2024
@dwiley-akamai dwiley-akamai self-assigned this Dec 2, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner December 2, 2024 23:02
@dwiley-akamai dwiley-akamai requested review from bnussman-akamai and hana-akamai and removed request for a team December 2, 2024 23:02
@dwiley-akamai dwiley-akamai marked this pull request as draft December 2, 2024 23:05
@bnussman-akamai
Copy link
Member

Ah yeah. This is what happened to me in #11285. Not sure why v9 is used over v7. Unfortunately, a ton has changed from eslint 7 to 9 so we can't just easily upgrade 😭 That's why I gave up and closed #11285 πŸ˜…

Screenshot 2024-12-02 at 6 33 26β€―PM

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸ”Ί 1 failing test on test run #1 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
1 Failing461 Passing2 Skipped97m 39s

Details

Failing Tests
SpecTest
❌linode-config.spec.tsEnd-to-End » Clones a config

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts"

@dwiley-akamai
Copy link
Contributor Author

Closing this in favor of #11280 as the eslint upgrade is a heavy lift at this juncture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants