Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8954] - Update @hookform/resolvers to latest #11349

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

bnussman-akamai
Copy link
Member

Description πŸ“

  • Updates @hookform/resolvers to latest πŸ“¦
  • Brings enhanced type-safety and will unblock other efforts like M3-8956 ✨

Changes πŸ”„

Note

These changes were necessary to satisfy TypeScript now that yup resolvers are more type safe

  • Fixes incorrect CloudPulse alerting incorrect types / schemas
  • Replaces some instances of notRequired() with optional()
    • notRequired() means the value can be null, undefined, or not present
    • optional() means the value can be undefined or not present
    • This change was needed to make our resolvers satisfy/match the types defined in api-v4
  • Added missing fields on CreateBucketSchema
  • Fixed deprecations and cleaned up the Linode Create resolver

Preview πŸ“·

Note

There should be no UI changes

How to test πŸ§ͺ

  • Check for schema regressions
    • Manually test affected forms
    • Verify cypress tests pass for affected forms
Author Checklists

As an Author, to speed up the review process, I considered πŸ€”

πŸ‘€ Doing a self review
❔ Our contribution guidelines
🀏 Splitting feature into small PRs
βž• Adding a changeset
πŸ§ͺ Providing/improving test coverage
πŸ” Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
πŸ‘£ Providing comprehensive reproduction steps
πŸ“‘ Providing or updating our documentation
πŸ•› Scheduling a pair reviewing session
πŸ“± Providing mobile support
β™Ώ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed βœ…

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Dec 2, 2024
@bnussman-akamai bnussman-akamai self-assigned this Dec 2, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸŽ‰ 462 passing tests on test run #3 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
0 Failing462 Passing2 Skipped94m 47s

@bnussman-akamai bnussman-akamai marked this pull request as ready for review December 2, 2024 21:36
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner December 2, 2024 21:36
@bnussman-akamai bnussman-akamai requested review from mjac0bs and pmakode-akamai and removed request for a team December 2, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants