tests: [M3-8656] - Mock LKE creation flow + APL coverage #11347
Conversation
abailly-akamai
changed the title
abailly-akamai
added
Testing
e2e
| ended?: string; | ||
| description?: string; | ||
| ended?: string | null; | ||
| description?: string | null; |
There was a problem hiding this comment.
just noticed this when inspecting response. I don't think we need a changeset?
There was a problem hiding this comment.
Could be "fixed" but okay without one too
abailly-akamai
requested review from
cliu-akamai,
dwiley-akamai,
hkhalil-akamai and
jdamore-linode
and removed request for
a team
abailly-akamai
changed the title
abailly-akamai
changed the title
|
Coverage Report: ✅ |
|
👋🏼 Just created some merge conflicts here in the lke-create spec by merging in #11322. Hopefully they're easy to resolve - LKE-E test coverage is minimal and will be built out as we continue. Thanks for the clean up in this file; will follow suit going forward. |
Cloud Manager UI test results🎉 463 passing tests on test run #5 ↗︎
|
| ended?: string; | ||
| description?: string; | ||
| ended?: string | null; | ||
| description?: string | null; |
There was a problem hiding this comment.
Could be "fixed" but okay without one too
| ended?: string | null; | ||
| description?: string | null; |
There was a problem hiding this comment.
Should the ?s be removed? I think ended and description will always be in the response
| ended?: string | null; | |
| description?: string | null; | |
| ended: string | null; | |
| description: string | null; |
| cy.wait('@createCluster'); | ||
| cy.wait('@getCluster'); | ||
| cy.wait('@getClusterPools'); | ||
| cy.wait('@getDashboardUrl'); | ||
| cy.wait('@getControlPlaneACL'); | ||
| cy.wait('@getApiEndpoints'); | ||
| cy.wait('@getLinodeTypes'); |
There was a problem hiding this comment.
| cy.wait('@createCluster'); | |
| cy.wait('@getCluster'); | |
| cy.wait('@getClusterPools'); | |
| cy.wait('@getDashboardUrl'); | |
| cy.wait('@getControlPlaneACL'); | |
| cy.wait('@getApiEndpoints'); | |
| cy.wait('@getLinodeTypes'); | |
| cy.wait([ | |
| '@createCluster', | |
| '@getCluster', | |
| '@getClusterPools', | |
| '@getDashboardUrl', | |
| '@getControlPlaneACL', | |
| '@getApiEndpoints', | |
| '@getLinodeTypes' | |
| ]); |
| mockedLKEClusterPools, | ||
| mockedLKEClusterTypes | ||
| ); | ||
|
|
||
| it('can create an LKE cluster', () => { | ||
| cy.tag('method:e2e', 'purpose:dcTesting'); |
There was a problem hiding this comment.
Now that we are mocking, do we need to update these tags?
There was a problem hiding this comment.
Good catch! @abailly-akamai I think in this case you can remove the cy.tag(...) call altogether since it's not suitable for DC testing without real API requests 👍
Description 📝
PR to remove any "real" entity creation during the create cluster flow and add APL coverage to the create specs.
Note
The reason for mocking the main create flow is to avoid creating real clusters in the CI for security reasons.
Changes 🔄
How to test 🧪
Prerequisites
Verification steps
yarn cy:debug> selectlke-createAs an Author, to speed up the review process, I considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅