Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8917] - Replace one-off hardcoded color values with color tokens pt4 #11345

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

hasyed-akamai
Copy link
Contributor

@hasyed-akamai hasyed-akamai commented Dec 2, 2024

Description 📝

  • Replace one-off hardcoded color values with color tokens - Part 4
  • colorTokens are global tokens, and they are theme-agnostic.

Note

The new colors are based on design tokens and have been selected to closely match the existing colors.

Changes 🔄

  • Replaced #5ad865 with theme.tokens.color.Green[60] #65ba75
  • Replaced #1CB35C with theme.tokens.color.Green[70] #00b050
  • Replaced #f8f8f2 with theme.tokens.color.Yellow[5] #ffffeb
  • Replaced #e6db74 with theme.tokens.color.Yellow[50] #e8e86a
  • Replaced #32363b with theme.tokens.color.Neutrals[100] #343438
  • Replaced #17CF73 with theme.tokens.color.Green[70] #00b050
  • Replaced #00B159 with theme.tokens.color.Green[70] #00b050
  • Replaced #1f64b6 with theme.tokens.color.Ultramarine[80] #3a5ccc
  • Replaced #939598 with theme.tokens.color.Neutrals[50] #a3a3ab
  • Replaced #B8B8B8 with theme.tokens.color.Neutrals[50] #a3a3ab
  • Replaced #3683dc with theme.tokens.color.Ultramarine[70] #4067e5
  • Replaced #cce2ff with theme.tokens.color.Brand[30] #ceedfe
  • Replaced #888 with theme.tokens.color.Neutrals[60] #83838c
  • Replaced #616161 with theme.tokens.color.Neutrals[70] #696970
  • Replaced #02b159 with theme.tokens.color.Green[70] #00b050
  • Replaced #6e6e6e with theme.tokens.color.Neutrals[70] #696970
  • Replaced #979797 with theme.tokens.color.Neutrals[50] #a3a3ab
  • Replaced #777 with theme.tokens.color.Neutrals[70] #696970
  • Replaced #444 with theme.tokens.color.Ultramarine[80] #3a5ccc
  • Replaced #f5f6f7 with theme.tokens.color.Ultramarine[5] #f8faff
  • Replaced #343438 with theme.tokens.color.Neutrals[90] #3d3d42
  • Replaced #e1edfa with theme.tokens.color.Ultramarine[20] #e6edfe
  • Replaced #ededf4 with theme.tokens.color.Neutrals[10] #ededf2
  • Replaced #83868c with theme.tokens.color.Neutrals[60] #83838c
  • Replaced #c1c1c0 with theme.tokens.color.Neutrals[40] #c2c2ca
  • Replaced #2575d0 with theme.tokens.color.Ultramarine[70] #4067e5
  • Replaced #32363c with theme.tokens.color.Neutrals[90] #3d3d42
  • Replaced #888f91 with theme.tokens.color.Neutrals[60] #83838c
  • Replaced #999 with theme.tokens.color.Neutrals[50] #a3a3ab
  • Replaced #fbfbfb with theme.tokens.color.Neutrals[5] #f7f7fa
  • Replaced #3f8a4e with theme.tokens.color.Green[70] #00b050
  • Replaced #4FAD62 with theme.tokens.color.Green[60] #65ba75
  • Replaced #72BD81 with theme.tokens.color.Green[50] #97cf9c
  • Replaced #ADD8E6 with theme.tokens.color.Cyan[30] #aadee6
  • Replaced #eaeaf0 with theme.tokens.color.Ultramarine[10] #f0f4ff
  • Replaced #5c6470 with theme.tokens.color.Neutrals[70] #696970
  • Replaced #9DA4A6 with theme.tokens.color.Neutrals[50] #a3a3ab
  • Replaced #c4c4c4 with theme.tokens.color.Neutrals[40] #c2c2ca
  • Replaced #D6D7D9 with theme.tokens.color.Neutrals[30] #d6d6dd

Target release date 🗓️

N/A

Preview 📷

  • Slight change in the colors.
  • The new colors are based on design tokens and have been selected to closely match the existing colors.

How to test 🧪

  • Ensure everything builds properly
  • Use colorpicker to differentiate between the two colors

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hasyed-akamai hasyed-akamai self-assigned this Dec 2, 2024
@hasyed-akamai hasyed-akamai added Design Tokens Laying the groundwork for Design Tokens Work in Progress labels Dec 2, 2024
@hasyed-akamai hasyed-akamai changed the title Replace one-off hardcoded color values with color tokens pt4 refactor: [M3-8917] - Replace one-off hardcoded color values with color tokens pt4 Dec 3, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 462 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing462 Passing2 Skipped104m 50s

@hasyed-akamai hasyed-akamai marked this pull request as ready for review December 3, 2024 12:23
@hasyed-akamai hasyed-akamai requested a review from a team as a code owner December 3, 2024 12:23
@hasyed-akamai hasyed-akamai requested review from mjac0bs and abailly-akamai and removed request for a team December 3, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Tokens Laying the groundwork for Design Tokens Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants