-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8951] - Cypress tests for firewall rules drag and drop keyboard interaction #11341
Open
pmakode-akamai
wants to merge
12
commits into
linode:develop
Choose a base branch
from
pmakode-akamai:M3-8951-cypress-tests-firewall-rules-drag-and-drop-keyboard
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+585
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmakode-akamai
added
the
e2e
Indicates that a PR touches Cypress tests in some way
label
Nov 29, 2024
pmakode-akamai
requested review from
jdamore-linode,
hana-akamai,
abailly-akamai and
subsingh-akamai
and removed request for
a team
December 2, 2024 14:16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
@jdamore-linode wouldn't such a test belong to our component test suite?
Perhaps both have their use, but worth checking
Coverage Report: ✅ |
Cloud Manager UI test results🎉 470 passing tests on test run #10 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add cypress test for firewall rules table drag and drop keyboard interaction which was enhanced in #11127
CustomKeyboardSensor
functions correctly:KeyboardSensor
fromdnd-kit
to meet our specific requirements.CustomKeyboardSensor
, rather than the defaultKeyboardSensor
fromdnd-kit
.CustomKeyboardSensor
works as expected on smaller window sizes, especially when the vertical scrollbar is enabled. In contrast, the defaultKeyboardSensor
fromdnd-kit
does not function as intended in this scenario.Changes 🔄
Target release date 🗓️
N/A
How to test 🧪
OR
Test firewall-rules-drag-and-drop-keyboard.spec.ts using
CustomKeyboardSensor
works as expected (both for normal window sizes and when a smaller window with a vertical scrollbar is enabled).CustomKeyboardSensor
and thednd-kit
defaultKeyboardSensor
.CustomKeyboardSensor
with the defaultKeyboardSensor
fromdnd-kit
in theFirewallRuleTable.tsx
component, and vice-versa.CustomKeyboardSensor
and some of the tests (related to vertical scrollbar) will fail when using the defaultKeyboardSensor
, confirming thatCustomKeyboardSensor
is functioning correctly.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅