refactor: [M3-8637] - Make EditableText UI component pure

[bnussman-akamai]

Description 📝

• Fixes oversight in initial migration of EditableText from manager to ui 📁
• Updates EditableText to not depend on react-router-dom to keep our new component library pure 💧
  • Adds a prop to EditableText that allows consumers to pass a CustomLink component
• Unblocks pnpm - see this failure ❌

Preview 📷

How to test 🧪

• Check for regressions in Cloud Manager 👀
• Test the component in Storybook 📖
• Check new pattern for quality and correctness. Let me know if there is a better way to approach this 🗣️

---

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

• I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

• All unit tests are passing
• TypeScript compilation succeeded without errors
• Code passes all linting rules

[abailly-akamai]

This looks great to me, and the best approach I can think of.

Now, I feel like this brings a bigger question. Until what point do we decide to make a component pure and move it to the UI library?

Asking those question because our definition of pure perhaps needs clarification. Is a component pure because it does not use a third party package, or is its lack of side effects (btw it should be both!) - but in this case EditableText isn't pure, mainly because of its callbacks.

[linode-gh-bot]

Cloud Manager UI test results

🎉 462 passing tests on test run #5 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
0 Failing	462 Passing	2 Skipped	111m 49s