upcoming: [M3-8869] - Update types for NodeBalancer UDP support #11321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
dwiley-akamai and
hana-akamai
and removed request for
a team
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 462 passing tests on test run #9 ↗︎
|
dwiley-akamai
approved these changes
Dec 3, 2024
| "@linode/manager": Tech Stories | ||
| --- | ||
|
|
||
| Cleaned up NodeBalancer related types ([#11321](https://github.com/linode/manager/pull/11321)) |
There was a problem hiding this comment.
Suggested change
| Cleaned up NodeBalancer related types ([#11321](https://github.com/linode/manager/pull/11321)) | |
| Clean up NodeBalancer related types ([#11321](https://github.com/linode/manager/pull/11321)) |
Comment on lines
+210
to
+230
| const client_conn_throttle = number() | ||
| .min( | ||
| CONNECTION_THROTTLE.MIN, | ||
| `Client Connection Throttle must be between ${CONNECTION_THROTTLE.MIN} and ${CONNECTION_THROTTLE.MAX}.` | ||
| ) | ||
| .max( | ||
| CONNECTION_THROTTLE.MAX, | ||
| `Client Connection Throttle must be between ${CONNECTION_THROTTLE.MIN} and ${CONNECTION_THROTTLE.MAX}.` | ||
| ) | ||
| .typeError('Client Connection Throttle must be a number.'); | ||
|
|
||
| const client_udp_sess_throttle = number() | ||
| .min( | ||
| CONNECTION_THROTTLE.MIN, | ||
| `UDP Session Throttle must be between ${CONNECTION_THROTTLE.MIN} and ${CONNECTION_THROTTLE.MAX}.` | ||
| ) | ||
| .max( | ||
| CONNECTION_THROTTLE.MAX, | ||
| `UDP Session Throttle must be between ${CONNECTION_THROTTLE.MIN} and ${CONNECTION_THROTTLE.MAX}.` | ||
| ) | ||
| .typeError('UDP Session Throttle must be a number.'); |
There was a problem hiding this comment.
Can put the error messages that are used twice in their own constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
Note
No UI changes
How to test 🧪
M3-8869)As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅