Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8654] - Migrate Typography to UI package #11299

Conversation

hkhalil-akamai
Copy link
Contributor

Description 📝

Migrates the Typography component and updates all existing imports.

How to test 🧪

  • Verify Typography across the app
  • Verify associated Storybook story

@hkhalil-akamai hkhalil-akamai self-assigned this Nov 20, 2024
@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner November 20, 2024 22:13
@hkhalil-akamai hkhalil-akamai requested review from bnussman-akamai and coliu-akamai and removed request for a team November 20, 2024 22:13
Copy link

github-actions bot commented Nov 20, 2024

Coverage Report:
Base Coverage: 86.83%
Current Coverage: 86.82%

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah, thanks Hussain - 500+ files!! I wonder if this is the record for most files touched🤩

It got to the point where github just showed 'Load diff' for later files instead of the diff itself haha 😆

✅ storybook
✅ imports look good
✅ spot checked CM

For the e2e test failurs, they seem unrelated - locally, I kept getting Linode API failures (+ saw Joe's PR about linode-storage being flaky)

@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner November 22, 2024 17:36
@hkhalil-akamai hkhalil-akamai requested review from AzureLatte and removed request for a team November 22, 2024 17:36
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending checks pass ✅

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 455 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing455 Passing2 Skipped96m 0s

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Nov 22, 2024
@hkhalil-akamai hkhalil-akamai merged commit 31960f5 into linode:develop Nov 22, 2024
23 checks passed
Copy link

cypress bot commented Nov 22, 2024

Cloud Manager E2E    Run #6871

Run Properties:  status check failed Failed #6871  •  git commit 31960f539e: refactor: [M3-8654] - Migrate `Typography` to UI package (#11299)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6871
Run duration 41m 52s
Commit git commit 31960f539e: refactor: [M3-8654] - Migrate `Typography` to UI package (#11299)
Committer Hussain Khalil
View all properties for this run ↗︎

Test results
Tests that failed  Failures 9
Tests that were flaky  Flaky 8
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 446
View all changes introduced in this branch ↗︎

Tests for review

Failed  images/machine-image-upload.spec.ts • 4 failed tests

View Output Video

Test Artifacts
machine image > uploads machine image, mock finish event Screenshots Video
machine image > uploads machine image, mock upload canceled failed event Screenshots Video
machine image > uploads machine image, mock failed to decompress failed event Screenshots Video
machine image > uploads machine image, mock expired upload event Screenshots Video
Failed  linodes/switch-linode-state.spec.ts • 2 failed tests

View Output Video

Test Artifacts
switch linode state > powers off a linode from details page Screenshots Video
switch linode state > reboots a linode from landing page Screenshots Video
Failed  linodes/linode-config.spec.ts • 1 failed test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Failed  linodes/backup-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
linode backups > can capture a manual snapshot Screenshots Video
Failed  linodes/search-linodes.spec.ts • 1 failed test

View Output Video

Test Artifacts
Search Linodes > create a linode and make sure it shows up in the table and is searchable in main search tool Screenshots Video
Flakiness  linodes/switch-linode-state.spec.ts • 2 flaky tests

View Output Video

Test Artifacts
switch linode state > powers on a linode from details page Screenshots Video
switch linode state > reboots a linode from details page Screenshots Video
Flakiness  linodes/resize-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
resize linode > resizes a linode by decreasing size Screenshots Video
Flakiness  linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  linodes/update-linode-labels.spec.ts • 2 flaky tests

View Output Video

Test Artifacts
update linode label > updates a linode label from details page Screenshots Video
update linode label > updates a linode label from the "Settings" tab Screenshots Video
Flakiness  account/service-transfer.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Account service transfers > can initiate and cancel a service transfer Screenshots Video

The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.

@hkhalil-akamai hkhalil-akamai deleted the M3-8654-migrate-Typography-to-UI-package branch November 23, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants