-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8654] - Migrate Typography
to UI package
#11299
refactor: [M3-8654] - Migrate Typography
to UI package
#11299
Conversation
Coverage Report: ❌ |
…Typography-to-UI-package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woah, thanks Hussain - 500+ files!! I wonder if this is the record for most files touched🤩
It got to the point where github just showed 'Load diff' for later files instead of the diff itself haha 😆
✅ storybook
✅ imports look good
✅ spot checked CM
For the e2e test failurs, they seem unrelated - locally, I kept getting Linode API failures (+ saw Joe's PR about linode-storage being flaky)
…Typography-to-UI-package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending checks pass ✅
Cloud Manager UI test results🎉 455 passing tests on test run #4 ↗︎
|
Description 📝
Migrates the
Typography
component and updates all existing imports.How to test 🧪
Typography
across the app