Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc: [M3-8631] - Use pnpm as our package manager #11000

Closed
wants to merge 26 commits into from
Closed

poc: [M3-8631] - Use pnpm as our package manager #11000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a4e3705
attempt pnpm
bnussman Sep 5, 2024
df96b28
more progress
bnussman Sep 6, 2024
a9d8d49
test
bnussman Sep 6, 2024
c43e8ef
test
bnussman Sep 6, 2024
293cadc
work on precommit hooks
bnussman Sep 6, 2024
c9783a8
work on precommit hooks
bnussman Sep 6, 2024
b8ba3be
init huskey
bnussman Sep 6, 2024
6b44349
updtae lockfile
bnussman Sep 23, 2024
c67d2b7
Merge branch 'develop' into poc/pnpm-sep-2024
bnussman Sep 24, 2024
59395e2
fixes
bnussman Sep 24, 2024
4f75477
get lint github action working
bnussman Sep 24, 2024
dc7186c
update more github actions
bnussman Sep 24, 2024
61730dc
revert small change
bnussman Sep 24, 2024
9a473b5
try to clean up artifact upload and download
bnussman Sep 24, 2024
da5df65
try to get storybook build working
bnussman Sep 24, 2024
bbaca07
revert change
bnussman Sep 24, 2024
47a9db6
make storybook work
bnussman Sep 24, 2024
8222807
fix some unit tests
bnussman Sep 24, 2024
6237c10
use correct glob
bnussman Sep 24, 2024
9aff699
try to fix up tests
bnussman Sep 24, 2024
b40a37e
try to fix remaining unit tests
bnussman Sep 25, 2024
65fcfff
update fireall api url to attempt to fix test
bnussman Sep 25, 2024
84e9e9a
fix failing firewall test
bnussman Sep 25, 2024
f173305
use corepack + pnpm
bnussman Sep 25, 2024
75d5175
let github actions use corepack version
bnussman Sep 25, 2024
6a58778
fix typescript version
bnussman Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
261 changes: 120 additions & 141 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,50 +15,46 @@ jobs:
package: ["linode-manager", "@linode/api-v4", "@linode/validation"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: pnpm/action-setup@v4
with:
node-version: "20.17"
- uses: actions/cache@v3
run_install: false
- uses: actions/setup-node@v4
with:
path: |
**/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- run: yarn --frozen-lockfile
- run: yarn workspace ${{ matrix.package }} run lint
node-version: "20.17"
cache: "pnpm"
- run: pnpm install --frozen-lockfile
- run: pnpm --filter ${{ matrix.package }} lint

build-validation:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
node-version: "20.17"
- uses: actions/cache@v3
run_install: false
- uses: actions/setup-node@v4
with:
path: |
**/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- run: yarn --frozen-lockfile
- run: yarn workspace @linode/validation run build
- uses: actions/upload-artifact@v3
node-version: "20.17"
cache: "pnpm"
- run: pnpm install --frozen-lockfile
- run: pnpm --filter @linode/validation run build
- uses: actions/upload-artifact@v4
with:
name: packages-validation-lib
path: |
packages/validation/index.js
packages/validation/lib
path: packages/validation/lib

publish-validation:
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/master'
needs:
- build-validation
needs: build-validation
steps:
- uses: actions/checkout@v2
- uses: actions/download-artifact@v2
- uses: actions/checkout@v4
- uses: actions/download-artifact@v4
with:
name: packages-validation-lib
path: packages/validation
path: packages/validation/lib
- uses: JS-DevTools/npm-publish@v1
id: npm-publish
with:
Expand All @@ -80,69 +76,61 @@ jobs:
runs-on: ubuntu-latest
needs: build-validation
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
node-version: "20.17"
- uses: actions/cache@v3
run_install: false
- uses: actions/setup-node@v4
with:
path: |
**/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- run: yarn --frozen-lockfile
- uses: actions/download-artifact@v3
node-version: "20.17"
cache: "pnpm"
- run: pnpm install --frozen-lockfile
- uses: actions/download-artifact@v4
with:
name: packages-validation-lib
path: packages/validation
- run: yarn workspace @linode/api-v4 run test
path: packages/validation/lib
- run: pnpm --filter @linode/api-v4 test

build-sdk:
runs-on: ubuntu-latest
needs:
- build-validation
needs: build-validation
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
node-version: "20.17"
- uses: actions/cache@v3
run_install: false
- uses: actions/setup-node@v4
with:
path: |
**/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- uses: actions/download-artifact@v3
node-version: "20.17"
cache: "pnpm"
- uses: actions/download-artifact@v4
with:
name: packages-validation-lib
path: packages/validation
- run: yarn --frozen-lockfile
- run: yarn workspace @linode/api-v4 run build
- uses: actions/upload-artifact@v3
path: packages/validation/lib
- run: pnpm install --frozen-lockfile
- run: pnpm --filter @linode/api-v4 build
- uses: actions/upload-artifact@v4
with:
name: packages-api-v4-lib
path: |
packages/api-v4/index.js
packages/api-v4/index.node.js
packages/api-v4/lib
path: packages/api-v4/lib

validate-sdk:
runs-on: ubuntu-latest
needs:
- build-sdk
needs: build-sdk
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: "20.17"

# Download the validation and api-v4 artifacts (built packages)
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: packages-validation-lib
path: packages/validation
- uses: actions/download-artifact@v3
path: packages/validation/lib
- uses: actions/download-artifact@v4
with:
name: packages-api-v4-lib
path: packages/api-v4
path: packages/api-v4/lib

# Create an api-v4 tarball
- run: cd packages/api-v4 && npm pack --pack-destination ../../
Expand All @@ -162,95 +150,89 @@ jobs:

test-manager:
runs-on: ubuntu-latest
needs:
- build-sdk
needs: build-sdk
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
node-version: "20.17"
- uses: actions/cache@v3
run_install: false
- uses: actions/setup-node@v4
with:
path: |
**/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- uses: actions/download-artifact@v3
node-version: "20.17"
cache: "pnpm"
- uses: actions/download-artifact@v4
with:
name: packages-validation-lib
path: packages/validation
- uses: actions/download-artifact@v3
path: packages/validation/lib
- uses: actions/download-artifact@v4
with:
name: packages-api-v4-lib
path: packages/api-v4
- run: yarn --frozen-lockfile
- run: yarn workspace linode-manager run test
path: packages/api-v4/lib
- run: pnpm install --frozen-lockfile
- run: pnpm --filter @linode/manager test

test-search:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
node-version: "20.17"
- uses: actions/cache@v3
run_install: false
- uses: actions/setup-node@v4
with:
path: |
**/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- run: yarn --frozen-lockfile
- run: yarn workspace @linode/search run test
node-version: "20.17"
cache: "pnpm"
- run: pnpm install --frozen-lockfile
- run: pnpm --filter @linode/search test

typecheck-manager:
runs-on: ubuntu-latest
needs:
- build-sdk
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
node-version: "20.17"
- uses: actions/cache@v3
run_install: false
- uses: actions/setup-node@v4
with:
path: |
**/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- uses: actions/download-artifact@v3
node-version: "20.17"
cache: "pnpm"
- uses: actions/download-artifact@v4
with:
name: packages-validation-lib
path: packages/validation
- uses: actions/download-artifact@v3
path: packages/validation/lib
- uses: actions/download-artifact@v4
with:
name: packages-api-v4-lib
path: packages/api-v4
- run: yarn --frozen-lockfile
- run: yarn workspace linode-manager run typecheck
path: packages/api-v4/lib
- run: pnpm install --frozen-lockfile
- run: pnpm --filter @linode/manager typecheck

build-manager:
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/master'
needs:
- build-sdk
needs: build-sdk
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
node-version: "20.17"
- uses: actions/cache@v3
run_install: false
- uses: actions/setup-node@v4
with:
path: |
**/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- uses: actions/download-artifact@v3
node-version: "20.17"
cache: "pnpm"
- uses: actions/download-artifact@v4
with:
name: packages-validation-lib
path: packages/validation
- uses: actions/download-artifact@v3
path: packages/validation/lib
- uses: actions/download-artifact@v4
with:
name: packages-api-v4-lib
path: packages/api-v4
- run: yarn --frozen-lockfile
- run: yarn workspace linode-manager run build
- uses: actions/upload-artifact@v3
path: packages/api-v4/lib
- run: pnpm install --frozen-lockfile
- run: pnpm install @linode/manager build
- uses: actions/upload-artifact@v4
with:
name: packages-manager-build
path: packages/manager/build
Expand All @@ -264,11 +246,11 @@ jobs:
# If the validation publish failed we could have mismatched versions and a broken JS client
- publish-validation
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
- uses: actions/checkout@v4
- uses: actions/download-artifact@v4
with:
name: packages-api-v4-lib
path: packages/api-v4
path: packages/api-v4/lib
- uses: JS-DevTools/npm-publish@v1
id: npm-publish
with:
Expand All @@ -288,43 +270,40 @@ jobs:

build-storybook:
runs-on: ubuntu-latest
needs:
- build-sdk
needs: build-sdk
env:
NODE_OPTIONS: --max-old-space-size=4096
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
node-version: "20.17"
- uses: actions/cache@v3
run_install: false
- uses: actions/setup-node@v4
with:
path: |
**/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- uses: actions/download-artifact@v3
node-version: "20.17"
cache: "pnpm"
- uses: actions/download-artifact@v4
with:
name: packages-validation-lib
path: packages/validation
- uses: actions/download-artifact@v3
path: packages/validation/lib
- uses: actions/download-artifact@v4
with:
name: packages-api-v4-lib
path: packages/api-v4
- run: yarn --frozen-lockfile
- run: yarn workspace linode-manager run build-storybook
- uses: actions/upload-artifact@v3
path: packages/api-v4/lib
- run: pnpm install --frozen-lockfile
- run: pnpm --filter @linode/manager build-storybook
- uses: actions/upload-artifact@v4
with:
name: storybook-build
path: packages/manager/storybook-static

publish-storybook:
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/master'
needs:
- build-storybook
needs: build-storybook
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
- uses: actions/checkout@v4
- uses: actions/download-artifact@v4
with:
name: storybook-build
path: storybook/build
Expand Down
2 changes: 1 addition & 1 deletion .husky/pre-commit
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
yarn workspaces run precommit
pnpm run --parallel precommit
Loading
Loading