Skip to content

Commit

Permalink
Address feedback: use CDS 2.0 icons
Browse files Browse the repository at this point in the history
  • Loading branch information
mjac0bs committed Nov 19, 2024
1 parent 55d86aa commit 796bd32
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 9 deletions.
4 changes: 4 additions & 0 deletions packages/manager/src/assets/icons/visibilityHide.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions packages/manager/src/assets/icons/visibilityShow.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,9 @@ export const ContactInformation = React.memo((props: Props) => {
}
sx={(theme) => ({
'& svg': {
color: theme.palette.primary.main,
'& path': {
stroke: theme.palette.primary.main,
},
},
marginRight: 2,
})}
Expand Down
19 changes: 11 additions & 8 deletions packages/ui/src/components/VisibilityTooltip/VisibilityTooltip.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import VisibilityIcon from '@mui/icons-material/Visibility';
import VisibilityOffIcon from '@mui/icons-material/VisibilityOff';
import VisibilityShowIcon from 'src/assets/icons/visibilityShow.svg';
import VisibilityHideIcon from 'src/assets/icons/visibilityHide.svg';

import { styled } from '@mui/material/styles';
import React from 'react';

Expand Down Expand Up @@ -44,9 +45,9 @@ export const VisibilityTooltip = (props: Props) => {
>
<StyledToggleButton onClick={handleClick}>
{!isVisible ? (
<VisibilityIcon aria-label="Show" />
<VisibilityShowIcon aria-label="Show" />
) : (
<VisibilityOffIcon aria-label="Hide" />
<VisibilityHideIcon aria-label="Hide" />
)}
{label}
</StyledToggleButton>
Expand All @@ -58,13 +59,15 @@ const StyledToggleButton = styled(IconButton, {
label: 'StyledToggleButton',
})(({ theme }) => ({
'& svg': {
color: theme.palette.grey[500],
fontSize: '0.875rem',
'& path': {
stroke: theme.palette.grey[500],
},
},
'& svg:hover': {
color: theme.palette.primary.main,
'& path': {
stroke: theme.palette.primary.main,
},
},
fontSize: '0.875rem',
marginLeft: theme.spacing(),
minHeight: 'auto',
minWidth: 'auto',
Expand Down

0 comments on commit 796bd32

Please sign in to comment.