Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to mark internal network as external #235

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

Michkov
Copy link
Contributor

@Michkov Michkov commented Sep 25, 2024

With new enviroment variable LINODE_EXTERNAL_SUBNET is possible to set internal network subnet to be used as external network.

Useful for running on testing Linode cloud instances which are providing external IP addresses in internal network.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

With new enviroment variable `LINODE_EXTERNAL_SUBNET` is possible to set
internal network subnet to be used as external network.

Useful for running on testing Linode cloud instances which are providing
external IP addresses in internal network.
@Michkov Michkov mentioned this pull request Sep 25, 2024
10 tasks
@Michkov Michkov changed the title Allow mark internal network as external Allow to mark internal network as external Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.48%. Comparing base (76dea77) to head (fab127d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cloud/linode/node_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   55.39%   55.48%   +0.09%     
==========================================
  Files          12       12              
  Lines        1883     1887       +4     
==========================================
+ Hits         1043     1047       +4     
  Misses        696      696              
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, haven't run and tested the code, but otherwise looks good to me.

README.md Outdated Show resolved Hide resolved
@Michkov Michkov merged commit 291e46f into main Sep 26, 2024
5 checks passed
@Michkov Michkov deleted the external-network-definition branch September 26, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants