-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to mark internal network as external #235
Conversation
With new enviroment variable `LINODE_EXTERNAL_SUBNET` is possible to set internal network subnet to be used as external network. Useful for running on testing Linode cloud instances which are providing external IP addresses in internal network.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 55.39% 55.48% +0.09%
==========================================
Files 12 12
Lines 1883 1887 +4
==========================================
+ Hits 1043 1047 +4
Misses 696 696
Partials 144 144 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, haven't run and tested the code, but otherwise looks good to me.
With new enviroment variable
LINODE_EXTERNAL_SUBNET
is possible to set internal network subnet to be used as external network.Useful for running on testing Linode cloud instances which are providing external IP addresses in internal network.
General:
Pull Request Guidelines: