Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not scrape kube metrics by default #904

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

j-zimnowoda
Copy link
Contributor

fixes #900

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

Copy link
Contributor

@staticvoid255 staticvoid255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling by default is a good decision. I do plan on providing monitoring for these services for the client, but since there doesn't seem to be a consistent default location for these services between cloud providers, it's better to disable.

@j-zimnowoda j-zimnowoda merged commit 347afc1 into main Sep 19, 2022
@j-zimnowoda j-zimnowoda deleted the jeho/fix/alerts branch September 19, 2022 14:28
Ani1357 pushed a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical alerts constantly firing for Kube Proxy, Scheduler and ControllerManager
2 participants