Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple builds issues and tekton 1.25 support #1170

Merged
merged 7 commits into from
Jul 4, 2023
Merged

fix: multiple builds issues and tekton 1.25 support #1170

merged 7 commits into from
Jul 4, 2023

Conversation

srodenhuis
Copy link
Contributor

@srodenhuis srodenhuis commented Jul 2, 2023 •
edited by j-zimnowoda
Loading

This PR provides the following fixes for the builds feature in Otomi:

  • Remove PSP in tekton chart for 1.25 support
  • correct namespace name used for tekton pipelines
  • optimized pipeline and pipelinerun for docker (kaniko) using a dedicated push secret in a workspace
  • support for git-clone private otomi Gitea repos

Depends-on: linode/apl-tasks#80

@srodenhuis srodenhuis requested review from j-zimnowoda and Ani1357 July 2, 2023 22:46
Ani1357
Ani1357 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buildpack and Dockerfile builds are working as expected.

j-zimnowoda
j-zimnowoda requested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR I do not see that it uses corresponding version from otomi-tasks. Could you refer to it?

@j-zimnowoda j-zimnowoda self-requested a review July 4, 2023 05:46
j-zimnowoda
j-zimnowoda approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, I see that the last commit has already changed back versions to main.

@j-zimnowoda j-zimnowoda merged commit 3dac623 into main Jul 4, 2023
@j-zimnowoda j-zimnowoda deleted the sr/fix/tekton branch July 4, 2023 05:47
Ani1357 pushed a commit that referenced this pull request Oct 25, 2023
@srodenhuis
fix: multiple builds issues and tekton 1.25 support (#1170)
8189e76 
Co-authored-by: Jehoszafat Zimnowoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ani1357 Ani1357 Ani1357 approved these changes

@j-zimnowoda j-zimnowoda j-zimnowoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srodenhuis @j-zimnowoda @Ani1357