Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase PR #102 and update - prometheus metrics #116

Merged
merged 6 commits into from
Jan 8, 2019

Conversation

ruehowl
Copy link
Contributor

@ruehowl ruehowl commented Dec 26, 2018

PR #102 adding useful prometheus-metrics by @shaikatz was unfortunately closed. Credits to @shaikatz for his efforts. 👍 It seems there are no further attempts to get this merged. He might be busy with other works ;) I have rebased the same old PR #102 with the updated chaoskube code and hoping we can get this merged this time.

@shaikatz if you are still following this project your comments are highly apreciated. 👍

@shaikatz
Copy link

Thanks for continuing this effort @ruehowl , LGTM.
Sorry for abandoning that PR, I've left for a long vacation after that PR and didn't had chance to come back to it, but we still uses chaoskube and will be happy to see this PR merged.

@linki
Copy link
Owner

linki commented Jan 8, 2019

@ruehowl @shaikatz Thank you! I slightly changed the names of the metrics a little. I hope you like it.

@linki linki merged commit 835d66b into linki:master Jan 8, 2019
@linki
Copy link
Owner

linki commented Jan 8, 2019

Example output:

chaoskube_errors_total 23
chaoskube_intervals_total 53
chaoskube_pods_deleted_total 30
chaoskube_termination_duration_seconds_bucket{le="0.005"} 6
chaoskube_termination_duration_seconds_bucket{le="0.01"} 14
chaoskube_termination_duration_seconds_bucket{le="0.025"} 38
chaoskube_termination_duration_seconds_bucket{le="0.05"} 44
chaoskube_termination_duration_seconds_bucket{le="0.1"} 44
chaoskube_termination_duration_seconds_bucket{le="0.25"} 44
chaoskube_termination_duration_seconds_bucket{le="0.5"} 44
chaoskube_termination_duration_seconds_bucket{le="1"} 44
chaoskube_termination_duration_seconds_bucket{le="2.5"} 44
chaoskube_termination_duration_seconds_bucket{le="5"} 44
chaoskube_termination_duration_seconds_bucket{le="10"} 44
chaoskube_termination_duration_seconds_bucket{le="+Inf"} 44
chaoskube_termination_duration_seconds_sum 0.7035474789999998
chaoskube_termination_duration_seconds_count 44

@linki
Copy link
Owner

linki commented Jan 8, 2019

Released: https://github.com/linki/chaoskube/releases/tag/v0.12.0

Thank you @shaikatz and @ruehowl 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants