-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug with gracePeriod conversion #415
Comments
here's what we noticed in our cluster 🙃 |
🤦♂️ |
@pims Thanks for fixing this! 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a graceperiod is configured, it looks like the conversion to int64 is incorrect.
The issue is with:
since a duration default value is in nanoseconds, converting
gracePeriod
to int64 leads to using nanoseconds instead of seconds.Example at: https://go.dev/play/p/Ee-vADPoDPt
PR incoming.
The text was updated successfully, but these errors were encountered: