Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multicluster: normalize nginx configmap naming #4508

Merged
merged 1 commit into from
Jun 1, 2020
Merged

multicluster: normalize nginx configmap naming #4508

merged 1 commit into from
Jun 1, 2020

Conversation

mayankshah1607
Copy link
Contributor

Fixes #4505

Signed-off-by: Mayank Shah [email protected]

alpeb
alpeb approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
When merging, let's add a note in the commit message so we remember to mention this change in the next release notes, to warn people to delete the remaining nginx-configuration configmap when updating with linkerd mc install.

zaharidichev
zaharidichev approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@zaharidichev zaharidichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alpeb alpeb merged commit 2f710f4 into linkerd:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaharidichev zaharidichev zaharidichev approved these changes

@alpeb alpeb alpeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalize nginx configmap naming
3 participants
@mayankshah1607 @alpeb @zaharidichev