Remove unused metrics #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
adleong
approved these changes
Feb 10, 2018
|
|
|
Ah, looks like the issue I was seeing is actually #328 --- as far as I know this is ready to merge. |
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
Removed the `method` label from Prometheus, and removed HTTP methods from reports. Removed `StreamSummary` from reports and replaced it with a `u32` count of streams. Closes linkerd#266 Signed-off-by: Eliza Weisman <[email protected]>
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
* 80b4ec5 (tag: v0.1.13) Bump version to v0.1.13 (linkerd#324) * 6b23542 Add client support for server push (linkerd#314) * 6d8554a Reassign capacity from reset streams. (linkerd#320) * b116605 Check whether the send side is not idle, not the recv side (linkerd#313) * a4ed615 Check minimal versions (linkerd#322) * ea8b8ac Avoid prematurely unlinking streams in `send_reset`, in some cases. (linkerd#319) * 9bbbe7e Disable length_delimited deprecation warning. (linkerd#321) * 00ca534 Update examples to use new Tokio (linkerd#316) * 12e0d26 Added functions to access io::Error in h2::Error (linkerd#311) * 586106a Fix push promise frame parsing (linkerd#309) * 2b960b8 Add Reset::INTERNAL_ERROR helper to test support (linkerd#308) * d464c6b set deny(warnings) only when cfg(test) (linkerd#307) * b0db515 fix some autolinks that weren't resolving in docs (linkerd#305) * 66a5d11 Shutdown the stream along with connection (linkerd#304)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
methodlabel from Prometheus, and removed HTTP methods from reports. RemovedStreamSummaryfrom reports and replaced it with au32count of streams.Closes #266