Add federated service e2e test #13352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
adleong
force-pushed
the
alex/federated-e2e
branch
from
726ad8a to
ab16aa1
Compare
alpeb
approved these changes
Nov 22, 2024
Comment on lines
+26
to
+31
| if err := TestHelper.SwitchContext(contexts[testutil.TargetContextKey]); err != nil { | ||
| testutil.AnnotatedFatalf(t, | ||
| "failed to rebuild helper clientset with new context", | ||
| "failed to rebuild helper clientset with new context [%s]: %v", | ||
| contexts[testutil.TargetContextKey], err) | ||
| } |
There was a problem hiding this comment.
Seems like this is not required given we always specify contexts below.
There was a problem hiding this comment.
it's required to set the context correctly for creating the dataplane namespace.
Comment on lines
20
to
21
| // requests, then we'll see log messages indicating that the web-svc can't | ||
| // reach the voting-svc (because it's not running). |
There was a problem hiding this comment.
not that voting-svc isn't running, but that we're using the failed 🍩 requests to attest web-svc is getting called.
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.