Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export CRD templates #12166

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Export CRD templates #12166

merged 2 commits into from
Feb 27, 2024

Conversation

mateiidavid
Copy link
Member

For consistency, we should export our CRD templates in the same way we export normal control plane templates and extensions.

For consistency, we should export our CRD templates in the same way we
export normal control plane templates and extensions.

Signed-off-by: Matei David <[email protected]>
@mateiidavid mateiidavid requested a review from a team as a code owner February 27, 2024 13:30
Signed-off-by: Matei David <[email protected]>
Copy link
Member

@zaharidichev zaharidichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linkerd linkerd deleted a comment from zaharidichev Feb 27, 2024
@mateiidavid mateiidavid merged commit 1f74128 into main Feb 27, 2024
33 checks passed
@mateiidavid mateiidavid deleted the matei/export-crds branch February 27, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants