controller: add counter for items dropped from workqueue #12079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…controller workqueue Signed-off-by: Zahari Dichev <[email protected]>
mateiidavid
approved these changes
Feb 15, 2024
| @@ -23,6 +23,7 @@ const ( | |||
| UnfinishedWorkKey = "unfinished_work_seconds" | |||
| LongestRunningProcessorKey = "longest_running_processor_seconds" | |||
| RetriesKey = "retries_total" | |||
| DropsTotal = "drops_total" | |||
There was a problem hiding this comment.
a very inconsequential suggestion but wdyt of staying consistent with the rest of the naming here?
Suggested change
| DropsTotal = "drops_total" | |
| DropsTotalKey = "drops_total" |
Signed-off-by: Zahari Dichev <[email protected]>
Merged
adleong
added a commit
that referenced
this pull request
Feb 16, 2024
* Allowed the `MutatingWebhookConfig` timeout value to be configured ([#12028]) (thanks @mikebell90) * Added a counter for items dropped from destination controller workqueue ([#12079]) * Fixed a spurious `linkerd check` error when using container images with digests ([#12059]) * Fixed an issue where inbound policy could be incorrect after certain policy resources are deleted ([#12088]) [#12028]: #12028 [#12079]: #12079 [#12059]: #12059 [#12088]: #12088 Signed-off-by: Alex Leong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a metric that measures the number of items that have been discarded from the work queue in the external workloads controller due to the retries limit being exceeded.
Signed-off-by: Zahari Dichev [email protected]