Skip to content

Commit

Permalink
Don't skip pushing images if tag is already there (#5128)
Browse files Browse the repository at this point in the history
gcr.io has an issue that it's not possible to update multi-arch images
(see eclipse-che/che#16983 and open-policy-agent/gatekeeper#665).

We're now relying on ghcr.io instead, which I verified doesn't have this
bug, so we can stop skipping these pushes.
  • Loading branch information
alpeb authored Oct 23, 2020
1 parent 5c9d348 commit 5de85d9
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions bin/_docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,6 @@ docker_build() {

output_params="--load"
if [ -n "$DOCKER_MULTIARCH" ]; then

# Pushing multi-arch images to gcr.io with the same tag that already exists is not possible
# The issue is on gcr as pushing the same tag in docker hub works fine
# Related issues: https://github.com/eclipse/che/issues/16983, https://github.com/open-policy-agent/gatekeeper/issues/665
if (docker buildx imagetools inspect "$repo:$tag"); then
echo "Build skipped. Image already exists"
exit 0
fi

output_params="--platform $SUPPORTED_ARCHS"
if [ -n "$DOCKER_PUSH" ]; then
output_params+=" --push"
Expand Down

0 comments on commit 5de85d9

Please sign in to comment.