-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use cargo-action-fmt to annotate PRs #1492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
force-pushed
the
ver/cargo-action-fmt
branch
from
February 13, 2022 18:45
2950426
to
986185f
Compare
`cargo-action-fmt` reads `cargo` output and generates GitHub action errors that properly annotate source locations. This change updates our CI workflows to use `cargo-action-fmt` so that errors are more clearly annotated. Signed-off-by: Oliver Gould <[email protected]>
olix0r
force-pushed
the
ver/cargo-action-fmt
branch
from
February 13, 2022 19:46
986185f
to
ac8830c
Compare
mateiidavid
approved these changes
Feb 14, 2022
kleimkuhler
approved these changes
Feb 14, 2022
hawkw
approved these changes
Feb 14, 2022
Signed-off-by: Oliver Gould <[email protected]>
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Feb 15, 2022
This release updates the `tokio` and `tower` crates to unreleased versions to pickup workarounds for `Instant`-related panics that occur on Amazon Linux. This release also updates the proxy's configuration logic to stop logging errors when the inbound port configuration is empty. --- * build(deps): bump rustls from 0.20.2 to 0.20.3 (linkerd/linkerd2-proxy#1495) * build(deps): bump serde_json from 1.0.78 to 1.0.79 (linkerd/linkerd2-proxy#1494) * build(deps): bump hdrhistogram from 7.4.0 to 7.5.0 (linkerd/linkerd2-proxy#1493) * ci: Use cargo-action-fmt to annotate PRs (linkerd/linkerd2-proxy#1492) * Do not error when `LINKERD2_PROXY_INBOUND_PORTS` is empty (linkerd/linkerd2-proxy#1478) * build(deps): bump EmbarkStudios/cargo-deny-action from 1.2.11 to 1.2.12 (linkerd/linkerd2-proxy#1499) * Fix dockerfile (linkerd/linkerd2-proxy#1500) * Pin git deps for dependencies that have `Instant` workarounds (linkerd/linkerd2-proxy#1497)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Feb 15, 2022
This release updates the `tokio` and `tower` crates to unreleased versions to pickup workarounds for `Instant`-related panics that occur on Amazon Linux. This release also updates the proxy's configuration logic to stop logging errors when the inbound port configuration is empty. --- * build(deps): bump rustls from 0.20.2 to 0.20.3 (linkerd/linkerd2-proxy#1495) * build(deps): bump serde_json from 1.0.78 to 1.0.79 (linkerd/linkerd2-proxy#1494) * build(deps): bump hdrhistogram from 7.4.0 to 7.5.0 (linkerd/linkerd2-proxy#1493) * ci: Use cargo-action-fmt to annotate PRs (linkerd/linkerd2-proxy#1492) * Do not error when `LINKERD2_PROXY_INBOUND_PORTS` is empty (linkerd/linkerd2-proxy#1478) * build(deps): bump EmbarkStudios/cargo-deny-action from 1.2.11 to 1.2.12 (linkerd/linkerd2-proxy#1499) * Fix dockerfile (linkerd/linkerd2-proxy#1500) * Pin git deps for dependencies that have `Instant` workarounds (linkerd/linkerd2-proxy#1497)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-action-fmt
readscargo
output and generates GitHub actionerrors that properly annotate source locations.
This change updates our CI workflows to use
cargo-action-fmt
so thaterrors are more clearly annotated.