Skip to content

Commit

Permalink
deps: update to tokio 1.17.0 and tower 0.4.12, and unpatch (#1503)
Browse files Browse the repository at this point in the history 
This branch updates the proxy's dependencies on Tokio and Tower to
1.17.0 and 0.4.12, respectively. These releases contain fixes for panics
when `std::time::Instant` fails to be properly monotonic.

Previously, we were using Git dependencies to ensure we got these fixes.
Now, we can remove those patches, as the released versions of these
crates have the necessary changes.
  • Loading branch information
@hawkw
hawkw authored Feb 17, 2022
1 parent 120aea0 commit c876fe1
Show file tree
Hide file tree
Showing 29 changed files with 44 additions and 45 deletions.
19 changes: 12 additions & 7 deletions Cargo.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2381,8 +2381,9 @@ checksum = "cda74da7e1a664f795bb1f8a87ec406fb89a02522cf6e50620d016add6dbbf5c"

[[package]]
name = "tokio"
version = "1.16.1"
source = "git+https://github.com/tokio-rs/tokio#8fb15da8f83278a51deb5514f998062dd3d21afe"
version = "1.17.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "2af73ac49756f3f7c01172e34a23e5d0216f6c32333757c2c61feb2bbff5a5ee"
dependencies = [
"bytes",
"libc",
Expand Down Expand Up @@ -2422,7 +2423,8 @@ dependencies = [
[[package]]
name = "tokio-macros"
version = "1.7.0"
source = "git+https://github.com/tokio-rs/tokio#8fb15da8f83278a51deb5514f998062dd3d21afe"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "b557f72f448c511a979e2564e55d74e6c4432fc96ff4f6241bc6bded342643b7"
dependencies = [
"proc-macro2",
"quote",
Expand Down Expand Up @@ -2538,8 +2540,9 @@ dependencies = [

[[package]]
name = "tower"
version = "0.4.11"
source = "git+https://github.com/tower-rs/tower#386de64ab4deb23d7d38c359edf8875cf551b697"
version = "0.4.12"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "9a89fd63ad6adf737582df5db40d286574513c69a11dac5214dc3b5603d6713e"
dependencies = [
"futures-core",
"futures-util",
Expand All @@ -2558,12 +2561,14 @@ dependencies = [
[[package]]
name = "tower-layer"
version = "0.3.1"
source = "git+https://github.com/tower-rs/tower#386de64ab4deb23d7d38c359edf8875cf551b697"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "343bc9466d3fe6b0f960ef45960509f84480bf4fd96f92901afe7ff3df9d3a62"

[[package]]
name = "tower-service"
version = "0.3.1"
source = "git+https://github.com/tower-rs/tower#386de64ab4deb23d7d38c359edf8875cf551b697"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "360dfd1d6d30e05fda32ace2c8c70e9c0a9da713275777f5a4dbb8a1893930c6"

[[package]]
name = "tower-test"
Expand Down
4 changes: 0 additions & 4 deletions Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,3 @@ lto = true

[patch.crates-io]
webpki = { git = "https://github.com/linkerd/webpki", branch = "cert-dns-names-0.22" }
tokio = { git = "https://github.com/tokio-rs/tokio" }
tower = { git = "https://github.com/tower-rs/tower" }
tower-layer = { git = "https://github.com/tower-rs/tower" }
tower-service = { git = "https://github.com/tower-rs/tower" }
4 changes: 1 addition & 3 deletions deny.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ deny = [
{ name = "rustls", wrappers = ["tokio-rustls"] },
]
skip = [
# Waiting on a tokio release that updates parking_lot to v0.12.
# waiting on tracing-subscriber
{ name = "parking_lot", version = "0.11" },
{ name = "parking_lot_core", version = "0.8" },
# waiting on `h2` and `tower` releases that update h2 to v0.7
Expand All @@ -67,6 +67,4 @@ allow-registry = ["https://github.com/rust-lang/crates.io-index"]
[sources.allow-org]
github = [
"linkerd",
"tokio-rs",
"tower-rs",
]
2 changes: 1 addition & 1 deletion hyper-balance/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ futures = { version = "0.3", default-features = false }
http = "0.2"
hyper = "0.14"
pin-project = "1"
tower = { version = "0.4.11", default-features = false, features = ["load"] }
tower = { version = "0.4", default-features = false, features = ["load"] }
tokio = { version = "1", features = ["macros"] }

[dev-dependencies]
Expand Down
2 changes: 1 addition & 1 deletion linkerd/app/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ thiserror = "1.0"
tokio = { version = "1", features = ["rt"] }
tokio-stream = { version = "0.1.8", features = ["time", "sync"] }
tonic = { version = "0.6", default-features = false, features = ["prost"] }
tower = "0.4.11"
tower = "0.4"
tracing = "0.1.30"
4 changes: 2 additions & 2 deletions linkerd/app/core/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,15 @@ linkerd-trace-context = { path = "../../trace-context" }
regex = "1.5.4"
serde_json = "1"
thiserror = "1.0"
tokio = { version = "1", features = ["macros", "sync", "parking_lot"]}
tokio = { version = "1", features = ["macros", "sync", "parking_lot"] }
tokio-stream = { version = "0.1.8", features = ["time"] }
tonic = { version = "0.6", default-features = false, features = ["prost"] }
tracing = "0.1.30"
parking_lot = "0.12"
pin-project = "1"

[dependencies.tower]
version = "0.4.11"
version = "0.4"
default-features = false
features = [
"buffer",
Expand Down
4 changes: 2 additions & 2 deletions linkerd/app/gateway/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ linkerd-app-inbound = { path = "../inbound" }
linkerd-app-outbound = { path = "../outbound" }
thiserror = "1.0"
tokio = { version = "1", features = ["sync"] }
tower = { version = "0.4.11", default-features = false }
tower = { version = "0.4", default-features = false }
tracing = "0.1.30"

[dev-dependencies]
tokio = { version = "1", features = ["rt", "macros"] }
tokio-test = "0.4"
tower = { version = "0.4.11", default-features = false, features = ["util"] }
tower = { version = "0.4", default-features = false, features = ["util"] }
tower-test = "0.4"
linkerd-app-test = { path = "../test" }
2 changes: 1 addition & 1 deletion linkerd/app/inbound/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ parking_lot = "0.12"
thiserror = "1.0"
tokio = { version = "1", features = ["sync"] }
tonic = { version = "0.6", default-features = false }
tower = { version = "0.4.11", features = ["util"] }
tower = { version = "0.4", features = ["util"] }
tracing = "0.1.30"

[target.'cfg(fuzzing)'.dependencies]
Expand Down
2 changes: 1 addition & 1 deletion linkerd/app/integration/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ tokio = { version = "1", features = ["io-util", "net", "rt", "macros"] }
tokio-stream = { version = "0.1.8", features = ["sync"] }
tokio-rustls = "0.23.2"
rustls-pemfile = "0.3.0"
tower = { version = "0.4.11", default-features = false }
tower = { version = "0.4", default-features = false }
tonic = { version = "0.6", default-features = false }
tracing = "0.1.30"
tracing-subscriber = { version = "0.3", default-features = false, features = ["fmt", "std"] }
Expand Down
2 changes: 1 addition & 1 deletion linkerd/app/outbound/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ linkerd-retry = { path = "../../retry" }
parking_lot = "0.12"
thiserror = "1.0"
tokio = { version = "1", features = ["sync"] }
tower = { version = "0.4.11", features = ["util"] }
tower = { version = "0.4", features = ["util"] }
tracing = "0.1.30"
pin-project = "1"

Expand Down
2 changes: 1 addition & 1 deletion linkerd/app/test/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ regex = "1"
tokio = { version = "1", features = ["io-util", "net", "rt", "sync"] }
tokio-test = "0.4"
tokio-stream = { version = "0.1.8", features = ["sync"] }
tower = { version = "0.4.11", default-features = false }
tower = { version = "0.4", default-features = false }
tracing = "0.1.30"
thiserror = "1"

Expand Down
2 changes: 1 addition & 1 deletion linkerd/cache/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ linkerd-error = { path = "../error" }
linkerd-stack = { path = "../stack" }
parking_lot = "0.12"
tokio = { version = "1", default-features = false, features = ["macros", "rt", "sync", "time"] }
tower = { version = "0.4.11", default-features = false, features = ["util"] }
tower = { version = "0.4", default-features = false, features = ["util"] }
tracing = "0.1.30"

[dev-dependencies]
Expand Down
2 changes: 1 addition & 1 deletion linkerd/detect/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ linkerd-io = { path = "../io" }
linkerd-stack = { path = "../stack" }
tokio = { version = "1", features = ["time"] }
thiserror = "1.0"
tower = "0.4.11"
tower = "0.4"
tracing = "0.1.30"
2 changes: 1 addition & 1 deletion linkerd/http-classify/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ publish = false
http = "0.2"
linkerd-error = { path = "../error" }
linkerd-stack = { path = "../stack" }
tower = { version = "0.4.11", default-features = false }
tower = { version = "0.4", default-features = false }
2 changes: 1 addition & 1 deletion linkerd/http-metrics/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ linkerd-stack = { path = "../stack" }
parking_lot = "0.12"
pin-project = "1"
tokio = { version = "1", features = ["time"] }
tower = "0.4.11"
tower = "0.4"
tracing = "0.1.30"
2 changes: 1 addition & 1 deletion linkerd/proxy/api-resolve/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ http-body = "0.4"
pin-project = "1"
prost = "0.9"
tonic = { version = "0.6", default-features = false }
tower = { version = "0.4.11", default-features = false }
tower = { version = "0.4", default-features = false }
tracing = "0.1.30"
2 changes: 1 addition & 1 deletion linkerd/proxy/core/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ Core interfaces needed to implement proxy components
[dependencies]
futures = { version = "0.3", default-features = false }
linkerd-error = { path = "../../error" }
tower = { version = "0.4.11", default-features = false }
tower = { version = "0.4", default-features = false }
4 changes: 2 additions & 2 deletions linkerd/proxy/discover/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ linkerd-proxy-core = { path = "../core" }
linkerd-stack = { path = "../../stack" }
tokio = { version = "1", features = ["rt", "sync", "time"] }
tokio-util = "0.7"
tower = { version = "0.4.11", features = ["discover"] }
tower = { version = "0.4", features = ["discover"] }
tracing = "0.1.30"
pin-project = "1"

[dev-dependencies]
async-stream = "0.3"
tokio = { version = "1", features = ["macros"] }
tower = { version = "0.4.11", default-features = false, features = ["discover", "util"]}
tower = { version = "0.4", default-features = false, features = ["discover", "util"]}
4 changes: 2 additions & 2 deletions linkerd/proxy/dns-resolve/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ linkerd-dns = { path = "../../dns" }
linkerd-proxy-core = { path = "../core" }
linkerd-stack = { path = "../../stack" }
tokio = { version = "1", features = ["sync"] }
tokio-stream = { version = "0.1.8", features = ["sync"]}
tower = "0.4.11"
tokio-stream = { version = "0.1.8", features = ["sync"] }
tower = "0.4"
tracing = "0.1.30"
2 changes: 1 addition & 1 deletion linkerd/proxy/http/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ linkerd-stack = { path = "../../stack" }
rand = "0.8"
thiserror = "1.0"
tokio = { version = "1", features = ["time", "rt"] }
tower = { version = "0.4.11", default-features = false, features = ["balance", "load", "discover"] }
tower = { version = "0.4", default-features = false, features = ["balance", "load", "discover"] }
tracing = "0.1.30"
try-lock = "0.2"
pin-project = "1"
Expand Down
2 changes: 1 addition & 1 deletion linkerd/proxy/resolve/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ futures = { version = "0.3", default-features = false }
linkerd-error = { path = "../../error" }
linkerd-proxy-core = { path = "../core" }
thiserror = "1.0"
tower = "0.4.11"
tower = "0.4"
tracing = "0.1"
pin-project = "1"
4 changes: 2 additions & 2 deletions linkerd/proxy/tap/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ linkerd-tls = { path = "../../tls" }
parking_lot = "0.12"
rand = { version = "0.8" }
thiserror = "1.0"
tokio = { version = "1", features = ["time"]}
tower = { version = "0.4.11", default-features = false }
tokio = { version = "1", features = ["time"] }
tower = { version = "0.4", default-features = false }
tonic = { version = "0.6", default-features = false }
tracing = "0.1.30"
pin-project = "1"
Expand Down
2 changes: 1 addition & 1 deletion linkerd/proxy/tcp/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ linkerd-error = { path = "../../error" }
linkerd-stack = { path = "../../stack" }
rand = "0.8"
tokio = { version = "1" }
tower = { version = "0.4.11", default-features = false, features = ["balance", "load", "discover"] }
tower = { version = "0.4", default-features = false, features = ["balance", "load", "discover"] }
pin-project = "1"
2 changes: 1 addition & 1 deletion linkerd/reconnect/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ publish = false
linkerd-error = { path = "../error" }
linkerd-stack = { path = "../stack" }
futures = { version = "0.3", default-features = false }
tower = { version = "0.4.11", default-features = false }
tower = { version = "0.4", default-features = false }
tracing = "0.1.30"
pin-project = "1"

Expand Down
2 changes: 1 addition & 1 deletion linkerd/retry/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ publish = false
futures = { version = "0.3", default-features = false }
linkerd-error = { path = "../error" }
linkerd-stack = { path = "../stack" }
tower = { version = "0.4.11", default-features = false, features = ["retry"] }
tower = { version = "0.4", default-features = false, features = ["retry"] }
tracing = "0.1.30"
2 changes: 1 addition & 1 deletion linkerd/service-profiles/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ regex = "1.5.4"
tokio = { version = "1", features = ["macros", "rt", "sync", "time"] }
tokio-stream = { version = "0.1", features = ["sync"] }
tonic = { version = "0.6", default-features = false }
tower = { version = "0.4.11", features = [ "ready-cache", "retry", "util"] }
tower = { version = "0.4", features = [ "ready-cache", "retry", "util"] }
thiserror = "1"
tracing = "0.1.30"
pin-project = "1"
Expand Down
2 changes: 1 addition & 1 deletion linkerd/stack/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ parking_lot = "0.12"
pin-project = "1"
thiserror = "1"
tokio = { version = "1", features = ["time"] }
tower = { version = "0.4.11", features = ["filter", "util"] }
tower = { version = "0.4", features = ["filter", "util"] }
tracing = "0.1"

[dev-dependencies]
Expand Down
2 changes: 1 addition & 1 deletion linkerd/stack/metrics/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ publish = false
[dependencies]
linkerd-metrics = { path = "../../metrics" }
parking_lot = "0.12"
tower = { version = "0.4.11", default-features = false }
tower = { version = "0.4", default-features = false }
tokio = { version = "1", features = ["time"] }
2 changes: 1 addition & 1 deletion linkerd/stack/tracing/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ publish = false
futures = { version = "0.3", default-features = false }
linkerd-error = { path = "../../error" }
linkerd-stack = { path = ".." }
tower = "0.4.11"
tower = "0.4"
tracing = "0.1.30"

0 comments on commit c876fe1

Please sign in to comment.