Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LI-HOTFIX] Exclude logback as a dependency #509

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

gitlw
Copy link

@gitlw gitlw commented May 1, 2024

TICKET = N/A
LI_DESCRIPTION = Exclude logback as a dependency as the assumption is that log4j will be used.
Tested the change with a info level logging in one of the tools script and seeing that it's no longer showing up.
EXIT_CRITERIA = N/A

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

… be used

TICKET = N/A
LI_DESCRIPTION = Exclude logback the assumption we make is that log4j will be used
EXIT_CRITERIA = N/A
@gitlw gitlw enabled auto-merge (squash) May 1, 2024 23:22
Copy link

@groelofs groelofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to your commit message that this dependency can sneak in via LI ZK (as opposed to Apache ZK).

@gitlw gitlw merged commit 42e6fae into 3.0-li May 9, 2024
25 checks passed
@gitlw gitlw deleted the exclude_logback branch May 9, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants