Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LI-HOTFIX] Add backward compatible constructor for KafkaServer #492

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

kehuum
Copy link

@kehuum kehuum commented Nov 2, 2023

This pr adds back the 2.4 kafka compatible constructor for KafkaServer.

LI_DESCRIPTION =
In mario testing, we are using reflection to create scala KafkaServer classes in EmbeddedBroker where it's using the KafkaServer constructor in 2.4 with 4 params.

While moving to kafka 3.0, this constructor is removed and the new constructor (including deprecated one) requires a trait class KafkaActions, which is used to hook up with cruise control and doesn't have any implementation in kafka itself, making it impossible for mario/other library to construct it using reflection (requires concrete class).

EXIT_CRITERIA = We can deprecate this pr when either oss kafka provides concrete implementation for KafkaActions class or mario has found alternative ways of creating KafkaServer for integration testing.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@kehuum kehuum changed the title add backward compatible constructor for KafkaServer Add backward compatible constructor for KafkaServer Nov 2, 2023
@lmr3796
Copy link

lmr3796 commented Nov 2, 2023

Remember [LI-HOTFIX] and EXIT_CRITERIA

@kehuum kehuum changed the title Add backward compatible constructor for KafkaServer [LI-HOTFIX] Add backward compatible constructor for KafkaServer Nov 2, 2023
@kehuum kehuum merged commit e1e2830 into 3.0-li Nov 2, 2023
25 checks passed
@kehuum kehuum deleted the addC branch November 2, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants