[LI-HOTFIX] Add backward compatible constructor for KafkaServer #492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds back the 2.4 kafka compatible constructor for KafkaServer.
LI_DESCRIPTION =
In mario testing, we are using reflection to create scala KafkaServer classes in EmbeddedBroker where it's using the KafkaServer constructor in 2.4 with 4 params.
While moving to kafka 3.0, this constructor is removed and the new constructor (including deprecated one) requires a trait class KafkaActions, which is used to hook up with cruise control and doesn't have any implementation in kafka itself, making it impossible for mario/other library to construct it using reflection (requires concrete class).
EXIT_CRITERIA = We can deprecate this pr when either oss kafka provides concrete implementation for KafkaActions class or mario has found alternative ways of creating KafkaServer for integration testing.
Committer Checklist (excluded from commit message)