Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

place location provided by peg 0.9 onto the AST #706

Merged
merged 2 commits into from
Sep 12, 2016

Conversation

jimmyhchan
Copy link
Contributor

Since we are now using peg 0.9, it'll be useful to have the end line, end column and offset. Offset is useful for parser authors who want to splice on the file buffer (get the template text for a helper for instance).

Up for discussion:

  • I'm dumping all of location into the location property of the peg node for max back compat. It's meta data so it seems cleaner.
  • I'm removing the extra line/column from the ast so it's a breaking change

we are line and col from the AST so this is a breaking change
@sethkinast
Copy link
Contributor

I am so happy to get rid of the stuff off the AST

@sethkinast
Copy link
Contributor

You found the other line/col thing I was thinking of. I think this is great! I'll pull it in locally and spot check a bit before merging if someone else can review too.

@sethkinast sethkinast merged commit 43c0831 into linkedin:master Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants