Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transitive dependencies #22

Closed
vaughandroid opened this issue Sep 10, 2015 · 0 comments
Closed

Fix transitive dependencies #22

vaughandroid opened this issue Sep 10, 2015 · 0 comments

Comments

@vaughandroid
Copy link

As it stands, 3 dependencies are required to properly support Mockito:

androidTestCompile "com.crittercism.dexmaker:dexmaker:1.4"
androidTestCompile "com.crittercism.dexmaker:dexmaker-mockito:1.4"
androidTestCompile "com.crittercism.dexmaker:dexmaker-dx:1.4"

dexmaker-mockito doesn't work without the other two modules. Shouldn't it have transitive dependencies on them?

If the dexmaker module also depends on dexmaker-dx, it ought to have a transitive dependency too. (I'm not sure if this is the case though since I have no use for this particular configuration.)
@vaughandroid vaughandroid mentioned this issue Sep 12, 2015
Closed
@drewhannay drewhannay mentioned this issue Dec 1, 2016
Closed
drewhannay pushed a commit to drewhannay/dexmaker that referenced this issue Dec 5, 2016
Add publishing scripts and RELEASING.md file
62c0177 
Fixes linkedin#22 by properly configuring transitive dependencies in
the published pom files.
drewhannay pushed a commit to drewhannay/dexmaker that referenced this issue Dec 5, 2016
Add publishing scripts and RELEASING.md file
7ed304c 
Fixes linkedin#22 by properly configuring transitive dependencies in
the published pom files.
drewhannay pushed a commit to drewhannay/dexmaker that referenced this issue Dec 5, 2016
Add publishing scripts and RELEASING.md file
26be169 
Fixes linkedin#22 by properly configuring transitive dependencies in
the published pom files.
drewhannay pushed a commit to drewhannay/dexmaker that referenced this issue Dec 5, 2016
Add publishing scripts and RELEASING.md file
6ebb073 
Fixes linkedin#22 by properly configuring transitive dependencies in
the published pom files.
farhan-arshad-dev added a commit to farhan-arshad-dev/edx-app-android that referenced this issue Oct 16, 2018
@farhan-arshad-dev
Resolve DiscoveryLaunchScreenshotTest issue.
b1a4825 
- LEARNER-5799
- Move the png's to there respective directory.
- Add androidTestCompile "com.crittercism.dexmaker:dexmaker-dx:1.4" to properly support Mockito.

Ref Doc:
linkedin/dexmaker#22
farhan-arshad-dev added a commit to farhan-arshad-dev/edx-app-android that referenced this issue Oct 16, 2018
@farhan-arshad-dev
Resolve screenshot testing issue
d7a23af 
- LEARNER-5799
- Update updated facebook screenshoot lib to 0.8.0.
- Add androidTestImplementation "com.crittercism.dexmaker:dexmaker-dx:1.4" to properly support Mockito. linkedin/dexmaker#22
- Remove attributes from the screentshots in gradle file.
- Move the screenshots png's to the new directory named "API_21_NO_GP_XHDPI_768x1280_armeabi-v7a_".
- Include support-annotations module for androidTestImplementation for screenshot testing.
- Include multidex module for androidTestImplementation for screenshot testing.
- Update the make file commnds according to the updated facebook screenshoot lib.
@farhan-arshad-dev farhan-arshad-dev mentioned this issue Oct 16, 2018
Merged
farhan-arshad-dev added a commit to farhan-arshad-dev/edx-app-android that referenced this issue Oct 16, 2018
@farhan-arshad-dev
Resolve screenshot testing issue
b6d60f8 
- LEARNER-5799
- Update facebook screenshoot lib to 0.8.0.
- Add androidTestImplementation "com.crittercism.dexmaker:dexmaker-dx:1.4" to properly support Mockito. linkedin/dexmaker#22
- Move the screenshots png's to the new directory named "API_21_NO_GP_XHDPI_768x1280_armeabi-v7a_" as per requirment of screenshot lib update.
- Include support-annotations module for androidTestImplementation used in the test cases.
- Include multidex module for androidTestImplementation used in the test cases.
- Update Makefile commnds according to the updated facebook screenshoot lib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vaughandroid