Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calcite to fix handling of queries with nested group by #96

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

losipiuk
Copy link
Contributor

@losipiuk losipiuk commented Jun 1, 2021

Depends on the linkedin-calcite release which includes: linkedin/linkedin-calcite#38

Fixes: #72

cc: @wmoustafa @findepi

@findepi
Copy link
Contributor

findepi commented Jun 2, 2021

@losipiuk thank you!

@wmoustafa
Copy link
Contributor

wmoustafa commented Jun 7, 2021

Thanks @losipiuk! You can address the TODO item since linkedin/calcite version 1.21.0.146 is now published (thanks to @rzhang10).

Motivation for version bump is fix for handling
translation for queries with nested group by.
@losipiuk losipiuk marked this pull request as ready for review June 7, 2021 12:55
@losipiuk
Copy link
Contributor Author

losipiuk commented Jun 7, 2021

Thanks for heads up.
PTAL @wmoustafa

@losipiuk
Copy link
Contributor Author

losipiuk commented Jun 9, 2021

Friendly ping @wmoustafa :)

@wmoustafa wmoustafa merged commit 265ed15 into linkedin:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic inconsistency use coral convert hive query to presto
3 participants