[WIP DO NOT MERGE] Bump Calcite to preserve LATERALs in LATERAL UNNEST calls #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
RelNode type derivation on the Coral IR -> Spark SQL path was introduced in #507 in
ExtractUnionFunctionTransformerhere. The type derivation requires calling Calcite'svalidatefunction which was incorrectly dropping the LATERAL keyword, this was previously only fixed for... LATERAL (SELECT .....case but has since been fixed for.. LATERAL (UNNEST ...here.This PR bumps the Calcite version to include the fix and adds a new unit to ensure LATERALs are not dropped for views with the Coral IR -> Spark SQL type derivation (through
ExtractUnionFunctionTransformer).How was this patch tested?
./gradlew clean build