Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coral-Trino] Map some UDFs to Trino UDF #524

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

ljfgem
Copy link
Collaborator

@ljfgem ljfgem commented Aug 21, 2024

What changes are proposed in this pull request, and why are they necessary?

This PR maps some UDFs to Trino UDF, so users can query the Hive views using these UDFs after registering the corresponding Trino function names in Trino.

How was this patch tested?

./gradlew clean build, no other tests since it's just UDF registration.

Copy link
Contributor

@KevinGe00 KevinGe00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljfgem ljfgem merged commit 9e79488 into linkedin:master Aug 21, 2024
1 check passed
@@ -122,6 +122,15 @@ protected SqlCall transform(SqlCall sqlCall) {
"com.linkedin.stdudfs.urnextractor.hive.UrnExtractorFunctionWrapper", 1, "urn_extractor"),
new CoralRegistryOperatorRenameSqlCallTransformer(
"com.linkedin.stdudfs.hive.daliudfs.UrnExtractorFunctionWrapper", 1, "urn_extractor"),
new CoralRegistryOperatorRenameSqlCallTransformer("com.linkedin.groot.runtime.udf.spark.HasMemberConsentUDF", 3,
"has_member_consent"),
new CoralRegistryOperatorRenameSqlCallTransformer("com.linkedin.groot.runtime.udf.spark.RedactFieldIfUDF", 4,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be redact_field_if instead of urn_extractor right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants