Rename FallBackToLinkedInHiveUDFTransformer to HiveUDFTransformer
#522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmoustafa
reviewed
Aug 1, 2024
| @@ -27,10 +27,10 @@ | |||
| * we use this transformer to fall back to the original Hive UDF defined in | |||
| * {@link com.linkedin.coral.hive.hive2rel.functions.StaticHiveFunctionRegistry}. | |||
| * This is reasonable since Spark understands and has ability to run Hive UDF. | |||
| * Check `CoralSparkTest#testFallBackToLinkedInHiveUDFTransformer()` for an example. | |||
| * Check `CoralSparkTest#testHiveUDFTransformer()` for an example. | |||
There was a problem hiding this comment.
I am not sure if the Java doc makes a lot of sense. Could you revise the Java doc as well?
wmoustafa
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
This PR modified class name
FallBackToLinkedInHiveUDFTransformertoHiveUDFTransformerto avoid confusion and be aligned withTransportUDFTransformerHow was this patch tested?
Existing unit tests