Register Spark UDFs #513
Merged
Register Spark UDFs #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGe00
reviewed
Jun 27, 2024
| @@ -673,6 +673,13 @@ public boolean isOptional(int i) { | |||
| createAddUserDefinedFunction("com.linkedin.policy.decoration.udfs.RedactSecondarySchemaFieldIf", ARG1, family( | |||
| SqlTypeFamily.BOOLEAN, SqlTypeFamily.ANY, SqlTypeFamily.ARRAY, SqlTypeFamily.CHARACTER, SqlTypeFamily.ANY)); | |||
|
|
|||
| createAddUserDefinedFunction("com.linkedin.groot.runtime.udf.spark.HasMemberConsentUDF", ReturnTypes.BOOLEAN, | |||
There was a problem hiding this comment.
Could you add a quick comment explaining why we're adding spark UDFs in a class called StaticHiveFunctionRegistry? Could be confusing for open source contributors with no context.
There was a problem hiding this comment.
StaticHiveFunctionRegistry doesn't contain Hive UDFs only (check the java doc of this class), it contains all the UDFs (i.e. Hive UDF, Transport UDF, etc)
I don't think it's necessary to add comments for OSS contributors since they don't care about LinkedIn internal UDFs.
1fanwang
approved these changes
Jun 27, 2024
KevinGe00
pushed a commit
to KevinGe00/coral
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
Register several Spark UDFs.
How was this patch tested?
Tested on target views