coral-hive: Added support for WITH clauses #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wmoustafa @funcheetah @antumbde This is a follow-up diff to support WITH clauses in Hive. Please take a look when you get a chance. |
wmoustafa
reviewed
Aug 19, 2021
| @@ -62,6 +62,40 @@ public void testBasic() { | |||
| verifyRel(rel, expected); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testBasic2() { | |||
There was a problem hiding this comment.
Can we share the common code between testBasic and testBasic2?
There was a problem hiding this comment.
Just fixed it by extracting the common code into a separate function.
uzshao
force-pushed
the
with_clause_support
branch
from
b6a9571
to
67e49bb
Compare
|
@wmoustafa Can you take a look again? I extracted the common code, and also added one more test case on with. |
ljfgem
reviewed
Aug 19, 2021
|
|
||
| @Test | ||
| public void testWithNested() { | ||
| // Test if the code can handle the use of the second alias from the WithList |
There was a problem hiding this comment.
nit: the comment is the same as testWith2, should also be changed?
There was a problem hiding this comment.
Nice catch! Just pushed a fix to the comment.
uzshao
force-pushed
the
with_clause_support
branch
from
67e49bb
to
0861a08
Compare
wmoustafa
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.