Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.1.0 release #923

Merged
merged 3 commits into from
Jan 20, 2023
Merged

5.1.0 release #923

merged 3 commits into from
Jan 20, 2023

Conversation

ehoner
Copy link
Collaborator

@ehoner ehoner commented Jan 19, 2023 •
edited
Loading

Brooklin release. (New tag and release will be created following merge.)

@ehoner
Version 5.1.0-SNAPSHOT (#923)
46f8d4e 
* version 5.1.0
* Bumping version to 5.1.0-SNAPSHOT
* Update changelog
* Update README version badge
@ehoner ehoner marked this pull request as ready for review January 19, 2023 01:11
hshukla
hshukla approved these changes Jan 20, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
ryannedolan
ryannedolan approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@ryannedolan ryannedolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to be bumping major versions frequently. It may be useful to call out why this is a major bump, cuz I cannot really tell from the changelog.

@ehoner
Copy link
Collaborator Author

ehoner commented Jan 20, 2023

We seem to be bumping major versions frequently. It may be useful to call out why this is a major bump, cuz I cannot really tell from the changelog.

It was changed with the zookeeper dependency change #917. I will add that explanation too.

@ehoner ehoner merged commit bf47190 into master Jan 20, 2023
@ehoner ehoner deleted the 5.1.0 branch January 20, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshukla hshukla hshukla approved these changes

@ryannedolan ryannedolan ryannedolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehoner @ryannedolan @hshukla